diff mbox series

ARM: imx: Use correct SRC base address

Message ID 1605894684-310524-1-git-send-email-r.karszniewicz@phytec.de
State New
Headers show
Series ARM: imx: Use correct SRC base address | expand

Commit Message

Robert Karszniewicz Nov. 20, 2020, 5:51 p.m. UTC
Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
forgot to rename a variable, which caused the wrong address to be used
and, in our case, the ULL getting falsely identified as ULZ.

Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")

Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
---
 arch/arm/mach-imx/anatop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Robert Karszniewicz Nov. 20, 2020, 5:56 p.m. UTC | #1
On 11/20/20 6:51 PM, Robert Karszniewicz wrote:
> Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
> forgot to rename a variable, which caused the wrong address to be used
> and, in our case, the ULL getting falsely identified as ULZ.
> 
> Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")
> 
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> ---

Sorry, I failed to Cc: with send-email.
Fabio Estevam Nov. 20, 2020, 6:09 p.m. UTC | #2
Hi Robert,

On Fri, Nov 20, 2020 at 2:52 PM Robert Karszniewicz
<r.karszniewicz@phytec.de> wrote:
>
> Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
> forgot to rename a variable, which caused the wrong address to be used
> and, in our case, the ULL getting falsely identified as ULZ.
>
> Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")
>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Just a small suggestion: next time, please do not put a blank line
between Fixes and Signed-off-by tag.

Thanks
Robert Karszniewicz Nov. 20, 2020, 6:13 p.m. UTC | #3
On 11/20/20 7:09 PM, Fabio Estevam wrote:
> Hi Robert,
> 
> On Fri, Nov 20, 2020 at 2:52 PM Robert Karszniewicz
> <r.karszniewicz@phytec.de> wrote:
>>
>> Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
>> forgot to rename a variable, which caused the wrong address to be used
>> and, in our case, the ULL getting falsely identified as ULZ.
>>
>> Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")
>>
>> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> 
> Just a small suggestion: next time, please do not put a blank line
> between Fixes and Signed-off-by tag.

Understood, thank you!

> 
> Thanks
>
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/anatop.c b/arch/arm/mach-imx/anatop.c
index d841bed8664d..7bb47eb3fc07 100644
--- a/arch/arm/mach-imx/anatop.c
+++ b/arch/arm/mach-imx/anatop.c
@@ -136,7 +136,7 @@  void __init imx_init_revision_from_anatop(void)
 
 			src_np = of_find_compatible_node(NULL, NULL,
 						     "fsl,imx6ul-src");
-			src_base = of_iomap(np, 0);
+			src_base = of_iomap(src_np, 0);
 			of_node_put(src_np);
 			WARN_ON(!src_base);
 			sbmr2 = readl_relaxed(src_base + SRC_SBMR2);