diff mbox

[4/9] serial: stm32: fix pio transmit timeout

Message ID 1499958494-19354-5-git-send-email-bich.hemon@st.com
State New
Headers show

Commit Message

Bich HEMON July 13, 2017, 3:08 p.m. UTC
From: Gerald Baeza <gerald.baeza@st.com>


100µs was too short for low speed transmission
(9600bps)

Signed-off-by: Gerald Baeza <gerald.baeza@st.com>

Signed-off-by: Bich Hemon <bich.hemon@st.com>

---
 drivers/tty/serial/stm32-usart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

Comments

gregkh@linuxfoundation.org July 30, 2017, 2:32 p.m. UTC | #1
On Thu, Jul 13, 2017 at 03:08:28PM +0000, Bich HEMON wrote:
> From: Gerald Baeza <gerald.baeza@st.com>
> 
> 100µs was too short for low speed transmission
> (9600bps)
> 
> Signed-off-by: Gerald Baeza <gerald.baeza@st.com>
> Signed-off-by: Bich Hemon <bich.hemon@st.com>
> ---
>  drivers/tty/serial/stm32-usart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch did not apply :(
Bich HEMON July 31, 2017, 9:30 a.m. UTC | #2
Hi Greg,

On 07/30/2017 04:32 PM, Greg Kroah-Hartman wrote:
> On Thu, Jul 13, 2017 at 03:08:28PM +0000, Bich HEMON wrote:

>> From: Gerald Baeza <gerald.baeza@st.com>

>>

>> 100µs was too short for low speed transmission

>> (9600bps)

>>

>> Signed-off-by: Gerald Baeza <gerald.baeza@st.com>

>> Signed-off-by: Bich Hemon <bich.hemon@st.com>

>> ---

>>   drivers/tty/serial/stm32-usart.c | 2 +-

>>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> This patch did not apply :(

> 


I have rebased the patch on top of your tty-next branch . Please drop 
this patch as I will send you a new version.

Thx,

Bich
diff mbox

Patch

diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index a12d79c..ca61bfe 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -202,7 +202,7 @@  static void stm32_transmit_chars_pio(struct uart_port *port)
 	ret = readl_relaxed_poll_timeout_atomic(port->membase + ofs->isr,
 						isr,
 						(isr & USART_SR_TXE),
-						10, 100);
+						10, 100000);
 
 	if (ret)
 		dev_err(port->dev, "tx empty not set\n");