diff mbox

[v3] staging: bcm2835-audio: Remove the initialization of static pointers.

Message ID 1486511160-2992-1-git-send-email-abdallah.meziti.pro@gmail.com
State New
Headers show

Commit Message

AbdAllah-MEZITI Feb. 7, 2017, 11:45 p.m. UTC
In C a static pointer will be initialized to NULL.
The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
If an object that has static storage duration is not initialized
explicitly, then:
 __ if it has pointer type, it is initialized to a null pointer.

Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>

v2: -fix the line-wrapping of the changelog.
    -fix the ref. documentation: C99 standards release,
	and not the draft.
    -this patch is the Task 10 Eudyptula Challenge
	that only fix one code style problem.
v3: -fix the subject prefix: must be based on the previous submissions.
---
 drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Greg KH Feb. 9, 2017, 12:17 p.m. UTC | #1
On Wed, Feb 08, 2017 at 12:45:47AM +0100, AbdAllah-MEZITI wrote:
> In C a static pointer will be initialized to NULL.
> The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
> If an object that has static storage duration is not initialized
> explicitly, then:
>  __ if it has pointer type, it is initialized to a null pointer.
> 
> Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
> 
> v2: -fix the line-wrapping of the changelog.
>     -fix the ref. documentation: C99 standards release,
> 	and not the draft.
>     -this patch is the Task 10 Eudyptula Challenge
> 	that only fix one code style problem.
> v3: -fix the subject prefix: must be based on the previous submissions.
> ---
>  drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch does not apply to my tree at all, sorry.

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74d..265fe55 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/bcm2835-audio/bcm2835.c
@@ -28,8 +28,8 @@ 
  * to debug if we run into issues
  */
 
-static struct snd_card *g_card = NULL;
-static struct bcm2835_chip *g_chip = NULL;
+static struct snd_card *g_card;
+static struct bcm2835_chip *g_chip;
 
 static int snd_bcm2835_free(struct bcm2835_chip *chip)
 {