From patchwork Wed Aug 17 00:59:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nitin Chaudhary X-Patchwork-Id: 659862 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sDWCZ2Pfzz9t1F for ; Wed, 17 Aug 2016 11:02:02 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=GYhWkDtc; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZpDI-0006Et-Jk; Wed, 17 Aug 2016 01:00:12 +0000 Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZpD1-0005oK-IC for linux-arm-kernel@lists.infradead.org; Wed, 17 Aug 2016 00:59:56 +0000 Received: by mail-pa0-x242.google.com with SMTP id hh10so6023568pac.1 for ; Tue, 16 Aug 2016 17:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Lb3KyXtoH1u/5UVuI51i8mw09u1uFpH9fcLsm6+QRYI=; b=GYhWkDtcMS83uyCHrTNIFN/zg9IpqEBiOt1IWQzyz6srR6tA08MuYU3xoeQK85D3iU hR0bXmMyb8Qi4UOowsqWvqrLTKV5ry66S0/8NeJmJ7073UIfLnJifV8z2IB6+/oyw8At rogvcc55pB4d2ne6mhYPvtI2l5cDpMrVxx0Z0znd5txXkuYW44hgtXQIZJV0ubcOOrrH pFoHMo6UHhJ/5OT6314LY8De0O5QlZQrFLo0Egvz5fOMsE7VbJnG3Xi1/d6OW5yL+61O ihwXbfPF0FK5a+zNPJMoCZtgT3hioQ5g4RDsyUSHTzP5eNEfbfvivcJkXzVcj9yXAND4 fzcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Lb3KyXtoH1u/5UVuI51i8mw09u1uFpH9fcLsm6+QRYI=; b=CIYNiStEaSjNO2PEWcuVbR/Aty7A28tmMqhP1wpPdcgrBIYb511pwxbUr+jL8WbtCN 8IiQRrrTOHs6jmv4y/Wshmr/a0j6mkSqEEYKTDbim8dQu/DbgInJXsI2DSZqBnPxKUX0 z+v2sWvwqGaBCWkh30kksSayZmhIg8ExAkvybeBUNDpnu22FuOolWKeXa5oHsqSxcEdF zp+1c+oaiBYTsaOu7w1V1BSU0ftJ+T3ZXHUnBELhlRGvKNLV6ziyG3OFafgFBBvoNtnD iZR+S2KAGzFo5/cs26WAQfu6M39lBIDri9suUWyzdZEI0IJV3r6KrCQQOVPzn19In/A2 i8Dw== X-Gm-Message-State: AEkoouvMuVhLynZBhDgF58+EvtekHFkkIMPXqahB74bTLkGE2rap0R0yjvHJUkBuzKX4vw== X-Received: by 10.66.127.10 with SMTP id nc10mr68941527pab.109.1471395575924; Tue, 16 Aug 2016 17:59:35 -0700 (PDT) Received: from nitinc-Latitude-E6540.ims.dom (64-60-156-46.static-ip.telepacific.net. [64.60.156.46]) by smtp.gmail.com with ESMTPSA id e187sm42088601pfg.43.2016.08.16.17.59.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Aug 2016 17:59:35 -0700 (PDT) From: Nitin Chaudhary X-Google-Original-From: Nitin Chaudhary To: zhengyu.shen@nxp.com Subject: [PATCH 2/2] [i.MX6Q] Code cleanup & verification after fixing compilation error Date: Tue, 16 Aug 2016 17:59:21 -0700 Message-Id: <1471395561-30389-3-git-send-email-Nitin.Chaudhary@zii.aero> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1471395561-30389-1-git-send-email-Nitin.Chaudhary@zii.aero> References: <20160815223035.5429-1-zhengyu.shen@nxp.com> <1471395561-30389-1-git-send-email-Nitin.Chaudhary@zii.aero> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160816_175955_709899_7E1272FF X-CRM114-Status: GOOD ( 13.24 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c03:0:0:0:242 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (nitinchaudhary1289[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (nitinchaudhary1289[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nitin.Chaudhary@zii.aero, linux-arm-kernel@lists.infradead.org, cphealy@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org Cleanup the code after fixing build error in Zhengyu Shen's perf mmdc integrated driver. The error occured due to migration of CPU Hotplug notifiers to a state machine based mechanism. Made the necessary cha- nges into the code and tested the same on an i.MX6QP FSL Board. The changes allow clean compilation and work fine as well. The results are as follows: root@RDU2:~ perf stat -a -e mmdc/busy-cycles/,mmdc/read-accesses/,mmdc/read-byte s/,mmdc/total-cycles/,mmdc/write-accesses/,mmdc/write-bytes/ dd if=/dev/zero of= /dev/null bs=1M count=5000 5000+0 records in 5000+0 records out 5242880000 bytes (5.2 GB) copied, 5.4982 s, 954 MB/s Performance counter stats for 'system wide': 1597891298 mmdc/busy-cycles/ 28531959 mmdc/read-accesses/ 910.77 MB mmdc/read-bytes/ 2917082184 mmdc/total-cycles/ 27965222 mmdc/write-accesses/ 894.91 MB mmdc/write-bytes/ 5.527407668 seconds time elapsed But still need to check why the automatic power saving mode is not getting enabled in my board. Any help/guidance on the same will be appreciated. Signed-off-by: Nitin Chaudhary --- arch/arm/mach-imx/mmdc.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c index 95c222d..45790f5 100644 --- a/arch/arm/mach-imx/mmdc.c +++ b/arch/arm/mach-imx/mmdc.c @@ -204,9 +204,10 @@ static int mmdc_cpu_offline(unsigned int cpu) perf_pmu_migrate_context(&pmu_ptr->pmu, cpu, target); cpumask_set_cpu(target, &pmu_ptr->cpu); - /* - if(pmu_ptr->irq) - WARN_ON(irq_set_affinity_hint(pmu_ptr->irq, &pmu_ptr->cpu) != 0); + /* + * TODO: Need to check if we need it or not + * if(pmu_ptr->irq) + * WARN_ON(irq_set_affinity_hint(pmu_ptr->irq, &pmu_ptr->cpu) != 0); */ return 0; } @@ -374,7 +375,12 @@ static int imx_mmdc_probe(struct platform_device *pdev) if (unlikely(!timeout)) { pr_warn("%s: failed to enable automatic power saving\n", __func__); - //return -EBUSY; + + /* + * TODO: Need to check why Automatic Power saving is not + * getting enabled successfully. + * return -EBUSY; + */ } pmu_mmdc = kzalloc(sizeof(*pmu_mmdc), GFP_KERNEL);