diff mbox

[soc/next?] ARM: BCM53573: Initial support for Broadcom BCM53573 SoCs

Message ID 1470990396-23701-1-git-send-email-zajec5@gmail.com
State New
Headers show

Commit Message

Rafał Miłecki Aug. 12, 2016, 8:26 a.m. UTC
From: Rafał Miłecki <rafal@milecki.pl>

BCM53573 series is a new family with embedded wireless. By marketing
people it's sometimes called Northstar but it uses different CPU and has
different architecture so we need a new symbol for it.
Fortunately it shares some peripherals with other iProc based SoCs so we
will be able to reuse some drivers/bindings.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Resending as linux-arm-kernel ML rejected my e-mail due to the wrong address:
bcm-kernel-feedback-list@broadcom.com>
---
 MAINTAINERS               |  7 +++++++
 arch/arm/mach-bcm/Kconfig | 15 +++++++++++++++
 2 files changed, 22 insertions(+)

Comments

Jon Mason Aug. 16, 2016, 5:52 p.m. UTC | #1
On Fri, Aug 12, 2016 at 4:26 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM53573 series is a new family with embedded wireless. By marketing
> people it's sometimes called Northstar but it uses different CPU and has
> different architecture so we need a new symbol for it.
> Fortunately it shares some peripherals with other iProc based SoCs so we
> will be able to reuse some drivers/bindings.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> Resending as linux-arm-kernel ML rejected my e-mail due to the wrong address:
> bcm-kernel-feedback-list@broadcom.com>
> ---
>  MAINTAINERS               |  7 +++++++
>  arch/arm/mach-bcm/Kconfig | 15 +++++++++++++++
>  2 files changed, 22 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7304d2e..9e2db2e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2517,6 +2517,13 @@ F:       arch/arm/mach-bcm/bcm_5301x.c
>  F:     arch/arm/boot/dts/bcm5301x.dtsi
>  F:     arch/arm/boot/dts/bcm470*
>
> +BROADCOM BCM53573 ARM ARCHITECTURE
> +M:     Rafał Miłecki <rafal@milecki.pl>
> +L:     linux-arm-kernel@lists.infradead.org
> +S:     Maintained
> +F:     arch/arm/boot/dts/bcm53573*
> +F:     arch/arm/boot/dts/bcm47189*
> +
>  BROADCOM BCM63XX ARM ARCHITECTURE
>  M:     Florian Fainelli <f.fainelli@gmail.com>
>  L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index 5832dba..9a6c3ae 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -76,6 +76,21 @@ config ARCH_BCM_5301X
>           different SoC or with the older BCM47XX and BCM53XX based
>           network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx
>
> +config ARCH_BCM_53573
> +       bool "Broadcom BCM53573 SoC series support"
> +       depends on ARCH_MULTI_V7
> +       select ARCH_BCM_IPROC
> +       select HAVE_ARM_ARCH_TIMER
> +
> +       help
> +         BCM53573 series is set of SoCs using ARM Cortex-A7 CPUs with wireless
> +         embedded in the chipset.
> +         This SoC line is mostly used in home routers and is some cheaper
> +         alternative for Northstar family.
> +
> +         The base chip is BCM53573 and there are some packaging modifications
> +         like BCM47189 and BCM47452.
> +

This will put it under the "iProc" section.  I think we would want it
under the "Other Architectures" section.

Thanks,
Jon

>  comment "KONA architected SoCs"
>
>  config ARCH_BCM_MOBILE
> --
> 1.8.4.5
>
Rafał Miłecki Aug. 16, 2016, 7:39 p.m. UTC | #2
On 16 August 2016 at 19:52, Jon Mason <jon.mason@broadcom.com> wrote:
> On Fri, Aug 12, 2016 at 4:26 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> BCM53573 series is a new family with embedded wireless. By marketing
>> people it's sometimes called Northstar but it uses different CPU and has
>> different architecture so we need a new symbol for it.
>> Fortunately it shares some peripherals with other iProc based SoCs so we
>> will be able to reuse some drivers/bindings.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>> Resending as linux-arm-kernel ML rejected my e-mail due to the wrong address:
>> bcm-kernel-feedback-list@broadcom.com>
>> ---
>>  MAINTAINERS               |  7 +++++++
>>  arch/arm/mach-bcm/Kconfig | 15 +++++++++++++++
>>  2 files changed, 22 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 7304d2e..9e2db2e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2517,6 +2517,13 @@ F:       arch/arm/mach-bcm/bcm_5301x.c
>>  F:     arch/arm/boot/dts/bcm5301x.dtsi
>>  F:     arch/arm/boot/dts/bcm470*
>>
>> +BROADCOM BCM53573 ARM ARCHITECTURE
>> +M:     Rafał Miłecki <rafal@milecki.pl>
>> +L:     linux-arm-kernel@lists.infradead.org
>> +S:     Maintained
>> +F:     arch/arm/boot/dts/bcm53573*
>> +F:     arch/arm/boot/dts/bcm47189*
>> +
>>  BROADCOM BCM63XX ARM ARCHITECTURE
>>  M:     Florian Fainelli <f.fainelli@gmail.com>
>>  L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
>> index 5832dba..9a6c3ae 100644
>> --- a/arch/arm/mach-bcm/Kconfig
>> +++ b/arch/arm/mach-bcm/Kconfig
>> @@ -76,6 +76,21 @@ config ARCH_BCM_5301X
>>           different SoC or with the older BCM47XX and BCM53XX based
>>           network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx
>>
>> +config ARCH_BCM_53573
>> +       bool "Broadcom BCM53573 SoC series support"
>> +       depends on ARCH_MULTI_V7
>> +       select ARCH_BCM_IPROC
>> +       select HAVE_ARM_ARCH_TIMER
>> +
>> +       help
>> +         BCM53573 series is set of SoCs using ARM Cortex-A7 CPUs with wireless
>> +         embedded in the chipset.
>> +         This SoC line is mostly used in home routers and is some cheaper
>> +         alternative for Northstar family.
>> +
>> +         The base chip is BCM53573 and there are some packaging modifications
>> +         like BCM47189 and BCM47452.
>> +
>
> This will put it under the "iProc" section.  I think we would want it
> under the "Other Architectures" section.

Oh, we're still having some miscommunication here. I did this choice
based on Ray's e-mail where he said it's SoC sharing peripherals with
iProc ones:

On 10 August 2016 at 19:44, Ray Jui <ray.jui@broadcom.com> wrote:
> Out of curiosity, I searched the datasheet and found this is a wireless
> router SoC done by the WLAN team. It happens to share some peripherals with
> other iProc based SoCs.

Is this wrong then? Ray?
Florian Fainelli Aug. 21, 2016, 4:49 p.m. UTC | #3
On August 16, 2016 12:39:49 PM PDT, "Rafał Miłecki" <zajec5@gmail.com> wrote:
>On 16 August 2016 at 19:52, Jon Mason <jon.mason@broadcom.com> wrote:
>> On Fri, Aug 12, 2016 at 4:26 AM, Rafał Miłecki <zajec5@gmail.com>
>wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> BCM53573 series is a new family with embedded wireless. By marketing
>>> people it's sometimes called Northstar but it uses different CPU and
>has
>>> different architecture so we need a new symbol for it.
>>> Fortunately it shares some peripherals with other iProc based SoCs
>so we
>>> will be able to reuse some drivers/bindings.
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>> ---
>>> Resending as linux-arm-kernel ML rejected my e-mail due to the wrong
>address:
>>> bcm-kernel-feedback-list@broadcom.com>
>>> ---
>>>  MAINTAINERS               |  7 +++++++
>>>  arch/arm/mach-bcm/Kconfig | 15 +++++++++++++++
>>>  2 files changed, 22 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 7304d2e..9e2db2e 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2517,6 +2517,13 @@ F:       arch/arm/mach-bcm/bcm_5301x.c
>>>  F:     arch/arm/boot/dts/bcm5301x.dtsi
>>>  F:     arch/arm/boot/dts/bcm470*
>>>
>>> +BROADCOM BCM53573 ARM ARCHITECTURE
>>> +M:     Rafał Miłecki <rafal@milecki.pl>
>>> +L:     linux-arm-kernel@lists.infradead.org
>>> +S:     Maintained
>>> +F:     arch/arm/boot/dts/bcm53573*
>>> +F:     arch/arm/boot/dts/bcm47189*
>>> +
>>>  BROADCOM BCM63XX ARM ARCHITECTURE
>>>  M:     Florian Fainelli <f.fainelli@gmail.com>
>>>  L:     linux-arm-kernel@lists.infradead.org (moderated for
>non-subscribers)
>>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
>>> index 5832dba..9a6c3ae 100644
>>> --- a/arch/arm/mach-bcm/Kconfig
>>> +++ b/arch/arm/mach-bcm/Kconfig
>>> @@ -76,6 +76,21 @@ config ARCH_BCM_5301X
>>>           different SoC or with the older BCM47XX and BCM53XX based
>>>           network SoC using a MIPS CPU, they are supported by
>arch/mips/bcm47xx
>>>
>>> +config ARCH_BCM_53573
>>> +       bool "Broadcom BCM53573 SoC series support"
>>> +       depends on ARCH_MULTI_V7
>>> +       select ARCH_BCM_IPROC
>>> +       select HAVE_ARM_ARCH_TIMER
>>> +
>>> +       help
>>> +         BCM53573 series is set of SoCs using ARM Cortex-A7 CPUs
>with wireless
>>> +         embedded in the chipset.
>>> +         This SoC line is mostly used in home routers and is some
>cheaper
>>> +         alternative for Northstar family.
>>> +
>>> +         The base chip is BCM53573 and there are some packaging
>modifications
>>> +         like BCM47189 and BCM47452.
>>> +
>>
>> This will put it under the "iProc" section.  I think we would want it
>> under the "Other Architectures" section.
>
>Oh, we're still having some miscommunication here. I did this choice
>based on Ray's e-mail where he said it's SoC sharing peripherals with
>iProc ones:
>
>On 10 August 2016 at 19:44, Ray Jui <ray.jui@broadcom.com> wrote:
>> Out of curiosity, I searched the datasheet and found this is a
>wireless
>> router SoC done by the WLAN team. It happens to share some
>peripherals with
>> other iProc based SoCs.
>
>Is this wrong then? Ray?

What both Ray and Jon said does not contradict with each other, this platform uses some iProc peripherals (supposedly why the Broadcom SDK shows it as a Northstar), but is not a genuine iProc architecture as defined for e.g NS/NSP/NS2.

For consistency it sounds like we would want this symbol in Other architectures since only a few iProc peripherals are used.
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 7304d2e..9e2db2e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2517,6 +2517,13 @@  F:	arch/arm/mach-bcm/bcm_5301x.c
 F:	arch/arm/boot/dts/bcm5301x.dtsi
 F:	arch/arm/boot/dts/bcm470*
 
+BROADCOM BCM53573 ARM ARCHITECTURE
+M:	Rafał Miłecki <rafal@milecki.pl>
+L:	linux-arm-kernel@lists.infradead.org
+S:	Maintained
+F:	arch/arm/boot/dts/bcm53573*
+F:	arch/arm/boot/dts/bcm47189*
+
 BROADCOM BCM63XX ARM ARCHITECTURE
 M:	Florian Fainelli <f.fainelli@gmail.com>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 5832dba..9a6c3ae 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -76,6 +76,21 @@  config ARCH_BCM_5301X
 	  different SoC or with the older BCM47XX and BCM53XX based
 	  network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx
 
+config ARCH_BCM_53573
+	bool "Broadcom BCM53573 SoC series support"
+	depends on ARCH_MULTI_V7
+	select ARCH_BCM_IPROC
+	select HAVE_ARM_ARCH_TIMER
+
+	help
+	  BCM53573 series is set of SoCs using ARM Cortex-A7 CPUs with wireless
+	  embedded in the chipset.
+	  This SoC line is mostly used in home routers and is some cheaper
+	  alternative for Northstar family.
+
+	  The base chip is BCM53573 and there are some packaging modifications
+	  like BCM47189 and BCM47452.
+
 comment "KONA architected SoCs"
 
 config ARCH_BCM_MOBILE