diff mbox

ARM: imx6ul: Fix Micrel PHY mask

Message ID 1462995570-31055-1-git-send-email-festevam@gmail.com
State New
Headers show

Commit Message

Fabio Estevam May 11, 2016, 7:39 p.m. UTC 
From: Fabio Estevam <fabio.estevam@nxp.com>

The value used for Micrel PHY mask is not correct. Use the 
MICREL_PHY_ID_MASK definition instead.

Thanks to Jiri Luznicky for proposing the fix at
https://community.freescale.com/thread/387739

Cc: <stable@vger.kernel.org>
Fixes: 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/mach-imx/mach-imx6ul.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn May 11, 2016, 7:50 p.m. UTC | #1 
On Wed, May 11, 2016 at 04:39:30PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The value used for Micrel PHY mask is not correct. Use the 
> MICREL_PHY_ID_MASK definition instead.
> 
> Thanks to Jiri Luznicky for proposing the fix at
> https://community.freescale.com/thread/387739
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

It would be nice if drivers/net/phy/micrel.c was to use
MICREL_PHY_ID_MASK. But that is a different patch.

Thanks
	Andrew
Fabio Estevam May 11, 2016, 7:53 p.m. UTC | #2 
On Wed, May 11, 2016 at 4:50 PM, Andrew Lunn <andrew@lunn.ch> wrote:

> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> It would be nice if drivers/net/phy/micrel.c was to use
> MICREL_PHY_ID_MASK. But that is a different patch.

Good suggestion. I will submit a patch doing this. Thanks
Shawn Guo June 9, 2016, 12:50 p.m. UTC | #3 
On Wed, May 11, 2016 at 04:39:30PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The value used for Micrel PHY mask is not correct. Use the 
> MICREL_PHY_ID_MASK definition instead.
> 
> Thanks to Jiri Luznicky for proposing the fix at
> https://community.freescale.com/thread/387739
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.
diff mbox

Patch

diff --git a/arch/arm/mach-imx/mach-imx6ul.c b/arch/arm/mach-imx/mach-imx6ul.c
index a38b16b..b56de4b 100644
--- a/arch/arm/mach-imx/mach-imx6ul.c
+++ b/arch/arm/mach-imx/mach-imx6ul.c
@@ -46,7 +46,7 @@  static int ksz8081_phy_fixup(struct phy_device *dev)
 static void __init imx6ul_enet_phy_init(void)
 {
 	if (IS_BUILTIN(CONFIG_PHYLIB))
-		phy_register_fixup_for_uid(PHY_ID_KSZ8081, 0xffffffff,
+		phy_register_fixup_for_uid(PHY_ID_KSZ8081, MICREL_PHY_ID_MASK,
 					   ksz8081_phy_fixup);
 }