Message ID | 1442842703-5309-3-git-send-email-emilio.lopez@collabora.co.uk |
---|---|
State | New |
Headers | show |
Hello Emilio, On Mon, Sep 21, 2015 at 6:38 AM, Emilio López <emilio.lopez@collabora.co.uk> wrote: > Some EC implementations include a small nvram space used to store > verified boot context data. This boolean property lets us indicate > whether this space is available or not on a specific EC implementation. > > Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk> Looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, Javier
On Mon, 21 Sep 2015, Emilio López wrote: > Some EC implementations include a small nvram space used to store > verified boot context data. This boolean property lets us indicate > whether this space is available or not on a specific EC implementation. > > Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk> > --- > > Patch is new in v3, split from 3/4 > > Documentation/devicetree/bindings/mfd/cros-ec.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt > index 1777916..136e0c2 100644 > --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt > +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt > @@ -34,6 +34,10 @@ Required properties (LPC): > - compatible: "google,cros-ec-lpc" > - reg: List of (IO address, size) pairs defining the interface uses > > +Optional properties (all): > +- google,has-vbc-nvram: Some implementations of the EC include a small > + nvram space used to store verified boot context data. This boolean flag > + is used to specify whether this nvram is present or not. Is there no way to check for this at runtime? > Example for I2C: >
Hi Lee, On 22/09/15 21:34, Lee Jones wrote: > On Mon, 21 Sep 2015, Emilio López wrote: > >> Some EC implementations include a small nvram space used to store >> verified boot context data. This boolean property lets us indicate >> whether this space is available or not on a specific EC implementation. >> >> Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk> >> --- >> >> Patch is new in v3, split from 3/4 >> >> Documentation/devicetree/bindings/mfd/cros-ec.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt >> index 1777916..136e0c2 100644 >> --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt >> +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt >> @@ -34,6 +34,10 @@ Required properties (LPC): >> - compatible: "google,cros-ec-lpc" >> - reg: List of (IO address, size) pairs defining the interface uses >> >> +Optional properties (all): >> +- google,has-vbc-nvram: Some implementations of the EC include a small >> + nvram space used to store verified boot context data. This boolean flag >> + is used to specify whether this nvram is present or not. > > Is there no way to check for this at runtime? You can issue a read and see if it succeeds, but the problem is that some EC implementations return success even when they don't implement the functionality. Cheers, Emilio
On Mon, 21 Sep 2015, Emilio López wrote: > Some EC implementations include a small nvram space used to store > verified boot context data. This boolean property lets us indicate > whether this space is available or not on a specific EC implementation. > > Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk> > --- > > Patch is new in v3, split from 3/4 > > Documentation/devicetree/bindings/mfd/cros-ec.txt | 4 ++++ > 1 file changed, 4 insertions(+) Applied, thanks. > diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt > index 1777916..136e0c2 100644 > --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt > +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt > @@ -34,6 +34,10 @@ Required properties (LPC): > - compatible: "google,cros-ec-lpc" > - reg: List of (IO address, size) pairs defining the interface uses > > +Optional properties (all): > +- google,has-vbc-nvram: Some implementations of the EC include a small > + nvram space used to store verified boot context data. This boolean flag > + is used to specify whether this nvram is present or not. > > Example for I2C: >
diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt index 1777916..136e0c2 100644 --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt @@ -34,6 +34,10 @@ Required properties (LPC): - compatible: "google,cros-ec-lpc" - reg: List of (IO address, size) pairs defining the interface uses +Optional properties (all): +- google,has-vbc-nvram: Some implementations of the EC include a small + nvram space used to store verified boot context data. This boolean flag + is used to specify whether this nvram is present or not. Example for I2C:
Some EC implementations include a small nvram space used to store verified boot context data. This boolean property lets us indicate whether this space is available or not on a specific EC implementation. Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk> --- Patch is new in v3, split from 3/4 Documentation/devicetree/bindings/mfd/cros-ec.txt | 4 ++++ 1 file changed, 4 insertions(+)