diff mbox

pinctrl: bcm281xx: make Kconfig dependency more strict

Message ID 1411546524-13345-1-git-send-email-u.kleine-koenig@pengutronix.de
State New
Headers show

Commit Message

Uwe Kleine-König Sept. 24, 2014, 8:15 a.m. UTC 
This driver is only useful on BCM281xx, so let the driver depend on
ARCH_BCM_MOBILE but allow compile coverage testing.
The main benefit is that the driver isn't available to be selected for
machines that don't have the matching hardware.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
This patch was sent earlier when the Kconfig symbol was still named
"PINCTRL_CAPRI":

	Date: Tue,  1 Apr 2014 22:10:21 +0200
	Subject: [PATCH] pinctrl: capri: make Kconfig dependency more strict
	Message-Id: <1396383021-2295-1-git-send-email-u.kleine-koenig@pengutronix.de>

and got a

	Reviewed-by: Sherman Yin <syin@broadcom.com>

back then.

Best regards
Uwe

 drivers/pinctrl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij Sept. 25, 2014, 7:54 a.m. UTC | #1 
On Wed, Sep 24, 2014 at 10:15 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

> This driver is only useful on BCM281xx, so let the driver depend on
> ARCH_BCM_MOBILE but allow compile coverage testing.
> The main benefit is that the driver isn't available to be selected for
> machines that don't have the matching hardware.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> This patch was sent earlier when the Kconfig symbol was still named
> "PINCTRL_CAPRI":
>
>         Date: Tue,  1 Apr 2014 22:10:21 +0200
>         Subject: [PATCH] pinctrl: capri: make Kconfig dependency more strict
>         Message-Id: <1396383021-2295-1-git-send-email-u.kleine-koenig@pengutronix.de>
>
> and got a
>
>         Reviewed-by: Sherman Yin <syin@broadcom.com>
>
> back then.

Patch applied.

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index bfd2c2e9f6cd..a95d5ca6d830 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -86,7 +86,7 @@  config PINCTRL_BCM2835
 
 config PINCTRL_BCM281XX
 	bool "Broadcom BCM281xx pinctrl driver"
-	depends on OF
+	depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
 	select PINMUX
 	select PINCONF
 	select GENERIC_PINCONF