Message ID | 1409847105-27241-2-git-send-email-dinguyen@opensource.altera.com |
---|---|
State | New |
Headers | show |
On Thursday 04 September 2014 11:11:45 dinguyen@opensource.altera.com wrote: > Hi Arnd, Kevin and Olof, > > Please consider pulling this patch for v3.18. Boris had given me permission to > take this patch together with it's DTS component. The DTS portion was in the > previous pull request. I have no objections to the code, but I don't understand what you gain from merging it through arm-soc. There is no dependency between the driver and the dts entries in any way, you just need to have both in order for things to work. We can always pull in drivers with permission from the maintainer when there is a good reason to do that, but I don't see that reason for this patch, so I'd prefer to have Boris merge it through his tree, unless I'm missing something. Arnd
On Tue, Sep 09, 2014 at 04:59:07PM +0200, Arnd Bergmann wrote: > On Thursday 04 September 2014 11:11:45 dinguyen@opensource.altera.com wrote: > > Hi Arnd, Kevin and Olof, > > > > Please consider pulling this patch for v3.18. Boris had given me permission to > > take this patch together with it's DTS component. The DTS portion was in the > > previous pull request. > > I have no objections to the code, but I don't understand what you gain > from merging it through arm-soc. There is no dependency between the > driver and the dts entries in any way, you just need to have both in order > for things to work. This is why I wanted them to go together, for completeness... > We can always pull in drivers with permission from the maintainer when there > is a good reason to do that, but I don't see that reason for this patch, > so I'd prefer to have Boris merge it through his tree, unless I'm missing > something. ... but then Dinh suggested he takes it so... In any case, I don't care who takes it. Normally I'd take them without much ado but I'd suggest we make an exception this one time since I'm on vacation with flaky interwebs connection and doing pull requests and merging patches doesn't work as smoothly. So Arnd, if you take it this one time only, I'd appreciate it. Otherwise it'll have to wait until I get back. Thanks.
On Tuesday 09 September 2014 17:45:25 Borislav Petkov wrote: > > > We can always pull in drivers with permission from the maintainer when there > > is a good reason to do that, but I don't see that reason for this patch, > > so I'd prefer to have Boris merge it through his tree, unless I'm missing > > something. > > ... but then Dinh suggested he takes it so... In any case, I don't care > who takes it. Normally I'd take them without much ado but I'd suggest > we make an exception this one time since I'm on vacation with flaky > interwebs connection and doing pull requests and merging patches doesn't > work as smoothly. > > So Arnd, if you take it this one time only, I'd appreciate it. Otherwise > it'll have to wait until I get back. Sure, no problem. Pulled into next/driver in arm-soc now. Thanks for the quick reply, enjoy your vacation! Arnd
On Tue, Sep 09, 2014 at 05:53:40PM +0200, Arnd Bergmann wrote: > Sure, no problem. Pulled into next/driver in arm-soc now. > > Thanks for the quick reply, enjoy your vacation! Thanks Arnd, much appreciated!