| Message ID | 1405675890-8802-4-git-send-email-LW@KARO-electronics.de |
|---|---|
| State | New |
| Headers | show |
On Fri, Jul 18, 2014 at 11:31:24AM +0200, Lothar Waßmann wrote: > - remove comma after end of list delimiter > The empty entry must always be the last item in the list, thus there > is no point in having a trailing comma to facilitate adding > succeding entries. > Remove the comma, so that inadvertedly adding an entry after the end > of list sentinel will produce a compile time error rather than an > unreachable entry in the list. > - consistently use tabs for indentation > > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> > --- > drivers/usb/musb/musb_am335x.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/musb/musb_am335x.c b/drivers/usb/musb/musb_am335x.c > index 1e58ed2..164c868 100644 > --- a/drivers/usb/musb/musb_am335x.c > +++ b/drivers/usb/musb/musb_am335x.c > @@ -21,14 +21,14 @@ err: > > static const struct of_device_id am335x_child_of_match[] = { > { .compatible = "ti,am33xx-usb" }, > - { }, > + { } makes not difference, but fine. > }; > MODULE_DEVICE_TABLE(of, am335x_child_of_match); > > static struct platform_driver am335x_child_driver = { > .probe = am335x_child_probe, > - .driver = { > - .name = "am335x-usb-childs", > + .driver = { > + .name = "am335x-usb-childs", thanks, still not a bug fix. > .of_match_table = am335x_child_of_match, > }, > }; > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/usb/musb/musb_am335x.c b/drivers/usb/musb/musb_am335x.c index 1e58ed2..164c868 100644 --- a/drivers/usb/musb/musb_am335x.c +++ b/drivers/usb/musb/musb_am335x.c @@ -21,14 +21,14 @@ err: static const struct of_device_id am335x_child_of_match[] = { { .compatible = "ti,am33xx-usb" }, - { }, + { } }; MODULE_DEVICE_TABLE(of, am335x_child_of_match); static struct platform_driver am335x_child_driver = { .probe = am335x_child_probe, - .driver = { - .name = "am335x-usb-childs", + .driver = { + .name = "am335x-usb-childs", .of_match_table = am335x_child_of_match, }, };
- remove comma after end of list delimiter The empty entry must always be the last item in the list, thus there is no point in having a trailing comma to facilitate adding succeding entries. Remove the comma, so that inadvertedly adding an entry after the end of list sentinel will produce a compile time error rather than an unreachable entry in the list. - consistently use tabs for indentation Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> --- drivers/usb/musb/musb_am335x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)