| Message ID | 1397549245-3338-2-git-send-email-antoine.tenart@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
Hi Antoine, On Tue, 15 Apr 2014 01:07:24 -0700 Antoine Ténart <antoine.tenart@free-electrons.com> wrote: > The BG2Q has GPIOs driven by the dwapb GPIO driver. Add the LIBGPIO as a > dependency to be able to support them. > > Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> > --- > arch/arm/mach-berlin/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig > index 291f1cac6c3d..c31968712095 100644 > --- a/arch/arm/mach-berlin/Kconfig > +++ b/arch/arm/mach-berlin/Kconfig > @@ -28,6 +28,7 @@ config MACH_BERLIN_BG2Q > select CPU_V7 > select HAVE_ARM_TWD if SMP > select HAVE_SMP > + select ARCH_REQUIRE_GPIOLIB alphabetically sort. Others looks good ;) Thanks, Jisheng
On 04/15/2014 10:07 AM, Antoine Ténart wrote: > The BG2Q has GPIOs driven by the dwapb GPIO driver. Add the LIBGPIO as a > dependency to be able to support them. > > Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> > --- > arch/arm/mach-berlin/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig > index 291f1cac6c3d..c31968712095 100644 > --- a/arch/arm/mach-berlin/Kconfig > +++ b/arch/arm/mach-berlin/Kconfig > @@ -28,6 +28,7 @@ config MACH_BERLIN_BG2Q > select CPU_V7 > select HAVE_ARM_TWD if SMP > select HAVE_SMP > + select ARCH_REQUIRE_GPIOLIB Apart from Jisheng's comment, I think we can directly move it into arch/arm/Kconfig's MACH_BERLIN directly? Sebastian > endmenu > >
Hi Jisheng, On Tue, Apr 15, 2014 at 05:07:50PM +0800, Jisheng Zhang wrote: > On Tue, 15 Apr 2014 01:07:24 -0700 > Antoine Ténart <antoine.tenart@free-electrons.com> wrote: […] > > diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig > > index 291f1cac6c3d..c31968712095 100644 > > --- a/arch/arm/mach-berlin/Kconfig > > +++ b/arch/arm/mach-berlin/Kconfig > > @@ -28,6 +28,7 @@ config MACH_BERLIN_BG2Q > > select CPU_V7 > > select HAVE_ARM_TWD if SMP > > select HAVE_SMP > > + select ARCH_REQUIRE_GPIOLIB > > alphabetically sort. You're right, will do. Antoine
Sebastian, On Tue, Apr 15, 2014 at 11:16:49AM +0200, Sebastian Hesselbarth wrote: > On 04/15/2014 10:07 AM, Antoine Ténart wrote: […] > >diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig > >index 291f1cac6c3d..c31968712095 100644 > >--- a/arch/arm/mach-berlin/Kconfig > >+++ b/arch/arm/mach-berlin/Kconfig > >@@ -28,6 +28,7 @@ config MACH_BERLIN_BG2Q > > select CPU_V7 > > select HAVE_ARM_TWD if SMP > > select HAVE_SMP > >+ select ARCH_REQUIRE_GPIOLIB > > Apart from Jisheng's comment, I think we can directly move it > into arch/arm/Kconfig's MACH_BERLIN directly? I think so. Antoine
diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig index 291f1cac6c3d..c31968712095 100644 --- a/arch/arm/mach-berlin/Kconfig +++ b/arch/arm/mach-berlin/Kconfig @@ -28,6 +28,7 @@ config MACH_BERLIN_BG2Q select CPU_V7 select HAVE_ARM_TWD if SMP select HAVE_SMP + select ARCH_REQUIRE_GPIOLIB endmenu
The BG2Q has GPIOs driven by the dwapb GPIO driver. Add the LIBGPIO as a dependency to be able to support them. Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> --- arch/arm/mach-berlin/Kconfig | 1 + 1 file changed, 1 insertion(+)