| Message ID | 1396383021-2295-1-git-send-email-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
On 14-04-01 01:10 PM, Uwe Kleine-König wrote: > This driver is only useful on BCM281xx, so let the driver depend on > ARCH_BCM_MOBILE but allow compile coverage testing. > The main benefit is that the driver isn't available to be selected for > machines that don't have the matching hardware. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/pinctrl/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index e49324032611..072749816cb4 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -106,7 +106,7 @@ config PINCTRL_BCM2835 > > config PINCTRL_CAPRI > bool "Broadcom Capri pinctrl driver" > - depends on OF > + depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST) > select PINMUX > select PINCONF > select GENERIC_PINCONF > Looks good. Just wondering how you've come across this driver (and PINCTRL_MSM8X74)? Reviewed-by: Sherman Yin <syin@broadcom.com> Thanks, Sherman
Hello, On Wed, Apr 02, 2014 at 04:19:58PM -0700, Sherman Yin wrote: > On 14-04-01 01:10 PM, Uwe Kleine-König wrote: > >This driver is only useful on BCM281xx, so let the driver depend on > >ARCH_BCM_MOBILE but allow compile coverage testing. > >The main benefit is that the driver isn't available to be selected for > >machines that don't have the matching hardware. > > > >Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > >--- > > drivers/pinctrl/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > >index e49324032611..072749816cb4 100644 > >--- a/drivers/pinctrl/Kconfig > >+++ b/drivers/pinctrl/Kconfig > >@@ -106,7 +106,7 @@ config PINCTRL_BCM2835 > > > > config PINCTRL_CAPRI > > bool "Broadcom Capri pinctrl driver" > >- depends on OF > >+ depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST) > > select PINMUX > > select PINCONF > > select GENERIC_PINCONF > > > > Looks good. Just wondering how you've come across this driver (and > PINCTRL_MSM8X74)? Well, I was annoyed by being asked if I want to enable them for my efm32 machine during make oldconfig after updating the kernel. :-) > Reviewed-by: Sherman Yin <syin@broadcom.com> Thanks Uwe
On Tue, Apr 1, 2014 at 10:10 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > This driver is only useful on BCM281xx, so let the driver depend on > ARCH_BCM_MOBILE but allow compile coverage testing. > The main benefit is that the driver isn't available to be selected for > machines that don't have the matching hardware. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Sherman is renaming this driver so this patch does not apply. Please resubmit after the rename is upstream or something. Yours, Linus Walleij
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index e49324032611..072749816cb4 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -106,7 +106,7 @@ config PINCTRL_BCM2835 config PINCTRL_CAPRI bool "Broadcom Capri pinctrl driver" - depends on OF + depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST) select PINMUX select PINCONF select GENERIC_PINCONF
This driver is only useful on BCM281xx, so let the driver depend on ARCH_BCM_MOBILE but allow compile coverage testing. The main benefit is that the driver isn't available to be selected for machines that don't have the matching hardware. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)