diff mbox

[4/5] ARM: dts: tx53: add simple-panel support

Message ID 1395235721-13847-4-git-send-email-LW@KARO-electronics.de
State New
Headers show

Commit Message

Lothar Waßmann March 19, 2014, 1:28 p.m. UTC 
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 arch/arm/boot/dts/imx53-tx53-x13x.dts |   12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Shawn Guo March 22, 2014, 6:46 a.m. UTC | #1 
On Wed, Mar 19, 2014 at 02:28:40PM +0100, Lothar Waßmann wrote:
> 
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
>  arch/arm/boot/dts/imx53-tx53-x13x.dts |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> index 26b918e..86a964d 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> @@ -63,6 +63,18 @@
>  		default-brightness-level = <50>;
>  	};
>  
> +	panel0 {
> +		compatible = "simple-panel";

>From what I can see, "simple-panel" is not a documented compatible.

Shawn

> +		power-supply = <&reg_lcd_pwr0>;
> +		backlight = <&backlight0>;
> +	};
> +
> +	panel1 {
> +		compatible = "simple-panel";
> +		power-supply = <&reg_lcd_pwr1>;
> +		backlight = <&backlight1>;
> +	};
> +
>  	regulators {
>  		reg_lcd_pwr0: regulator@5 {
>  			compatible = "regulator-fixed";
> -- 
> 1.7.10.4
> 
> 
>
Lothar Waßmann March 25, 2014, 1:14 p.m. UTC | #2 
Hi,

Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:28:40PM +0100, Lothar Waßmann wrote:
> > 
> > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> > ---
> >  arch/arm/boot/dts/imx53-tx53-x13x.dts |   12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > index 26b918e..86a964d 100644
> > --- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > +++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > @@ -63,6 +63,18 @@
> >  		default-brightness-level = <50>;
> >  	};
> >  
> > +	panel0 {
> > +		compatible = "simple-panel";
> 
> From what I can see, "simple-panel" is not a documented compatible.
> 
There is Documentation/devicetree/bindings/panel/simple-panel.txt
which describes the bindings for drivers/gpu/drm/panel/panel-simple.c.
"simple-panel" is the common compatible for all panels that the driver
supports. If no compatible for a specific panel is given, the
driver supports a generic panel with an ENABLE GPIO, an attached
backlight and a regulator. This is what's being used here. 


Lothar Waßmann
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index 26b918e..86a964d 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -63,6 +63,18 @@ 
 		default-brightness-level = <50>;
 	};
 
+	panel0 {
+		compatible = "simple-panel";
+		power-supply = <&reg_lcd_pwr0>;
+		backlight = <&backlight0>;
+	};
+
+	panel1 {
+		compatible = "simple-panel";
+		power-supply = <&reg_lcd_pwr1>;
+		backlight = <&backlight1>;
+	};
+
 	regulators {
 		reg_lcd_pwr0: regulator@5 {
 			compatible = "regulator-fixed";