| Message ID | 1389029246-27434-1-git-send-email-dinguyen@altera.com |
|---|---|
| State | New |
| Headers | show |
Hi Mike, On 1/6/14 11:27 AM, dinguyen@altera.com wrote: > Hi Mike, > > Please pull in these patches that cleans up the SOCFPGA clock driver. This is > V2 of the pull request that includes 4 patches from Steffen Trumtrar. > > Thanks, > > Dinh > > The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae: > > Linux 3.13-rc1 (2013-11-22 11:30:55 -0800) > > are available in the git repository at: > > git://git.rocketboards.org/linux-socfpga-next.git tags/socfpga-clk-for-3.14_v2 > > for you to fetch changes up to d5387681665e58bafc1a9c745182f03aab0579c3: > > clk: socfpga: split clk code (2014-01-06 11:22:22 -0600) > > ---------------------------------------------------------------- > v2: SOCFPGA clk cleanups for 3.14 > > ---------------------------------------------------------------- > Dinh Nguyen (3): > clk: socfpga: Map the clk manager base address in the clock driver > clk: socfpga: Look for the GPIO_DB_CLK by its offset > clk: socfpga: Remove socfpga_init_clocks > > Steffen Trumtrar (4): > clk: socfpga: remove unused field > clk: socfpga: fix define typo > clk: socfpga: fix compile error > clk: socfpga: split clk code > > arch/arm/mach-socfpga/socfpga.c | 5 - > drivers/clk/socfpga/Makefile | 3 + > drivers/clk/socfpga/clk-gate.c | 223 ++++++++++++++++++++++++++ > drivers/clk/socfpga/clk-periph.c | 94 +++++++++++ > drivers/clk/socfpga/clk-pll.c | 111 +++++++++++++ > drivers/clk/socfpga/clk.c | 328 ++------------------------------------ > drivers/clk/socfpga/clk.h | 57 +++++++ > 7 files changed, 500 insertions(+), 321 deletions(-) > create mode 100644 drivers/clk/socfpga/clk-gate.c > create mode 100644 drivers/clk/socfpga/clk-periph.c > create mode 100644 drivers/clk/socfpga/clk-pll.c > create mode 100644 drivers/clk/socfpga/clk.h Please consider this pull-request. Thanks, Dinh
Quoting dinguyen@altera.com (2014-01-06 09:27:26) > Hi Mike, > > Please pull in these patches that cleans up the SOCFPGA clock driver. This is > V2 of the pull request that includes 4 patches from Steffen Trumtrar. > > Thanks, > > Dinh > > The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae: > > Linux 3.13-rc1 (2013-11-22 11:30:55 -0800) > > are available in the git repository at: > > git://git.rocketboards.org/linux-socfpga-next.git tags/socfpga-clk-for-3.14_v2 > > for you to fetch changes up to d5387681665e58bafc1a9c745182f03aab0579c3: > > clk: socfpga: split clk code (2014-01-06 11:22:22 -0600) > > ---------------------------------------------------------------- > v2: SOCFPGA clk cleanups for 3.14 > > ---------------------------------------------------------------- > Dinh Nguyen (3): > clk: socfpga: Map the clk manager base address in the clock driver > clk: socfpga: Look for the GPIO_DB_CLK by its offset Hi Dinh, Patch "clk: socfpga: Look for the GPIO_DB_CLK by its offset" still causes a compilation error. I know it gets fixed by "clk: socfpga: fix compile error" later on but this still breaks git bisect. Can you please fold the fixes into the patches that introduce the bugs? No need to keep them separate since they are all part of the same pull request. Regards, Mike > clk: socfpga: Remove socfpga_init_clocks > > Steffen Trumtrar (4): > clk: socfpga: remove unused field > clk: socfpga: fix define typo > clk: socfpga: fix compile error > clk: socfpga: split clk code > > arch/arm/mach-socfpga/socfpga.c | 5 - > drivers/clk/socfpga/Makefile | 3 + > drivers/clk/socfpga/clk-gate.c | 223 ++++++++++++++++++++++++++ > drivers/clk/socfpga/clk-periph.c | 94 +++++++++++ > drivers/clk/socfpga/clk-pll.c | 111 +++++++++++++ > drivers/clk/socfpga/clk.c | 328 ++------------------------------------ > drivers/clk/socfpga/clk.h | 57 +++++++ > 7 files changed, 500 insertions(+), 321 deletions(-) > create mode 100644 drivers/clk/socfpga/clk-gate.c > create mode 100644 drivers/clk/socfpga/clk-periph.c > create mode 100644 drivers/clk/socfpga/clk-pll.c > create mode 100644 drivers/clk/socfpga/clk.h >
On 1/14/14 10:32 PM, Mike Turquette wrote: > Quoting dinguyen@altera.com (2014-01-06 09:27:26) >> Hi Mike, >> >> Please pull in these patches that cleans up the SOCFPGA clock driver. This is >> V2 of the pull request that includes 4 patches from Steffen Trumtrar. >> >> Thanks, >> >> Dinh >> >> The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae: >> >> Linux 3.13-rc1 (2013-11-22 11:30:55 -0800) >> >> are available in the git repository at: >> >> git://git.rocketboards.org/linux-socfpga-next.git tags/socfpga-clk-for-3.14_v2 >> >> for you to fetch changes up to d5387681665e58bafc1a9c745182f03aab0579c3: >> >> clk: socfpga: split clk code (2014-01-06 11:22:22 -0600) >> >> ---------------------------------------------------------------- >> v2: SOCFPGA clk cleanups for 3.14 >> >> ---------------------------------------------------------------- >> Dinh Nguyen (3): >> clk: socfpga: Map the clk manager base address in the clock driver >> clk: socfpga: Look for the GPIO_DB_CLK by its offset > Hi Dinh, > > Patch "clk: socfpga: Look for the GPIO_DB_CLK by its offset" still > causes a compilation error. I know it gets fixed by "clk: socfpga: fix > compile error" later on but this still breaks git bisect. > > Can you please fold the fixes into the patches that introduce the bugs? > No need to keep them separate since they are all part of the same pull > request. I have sent you a v3 of the pull request that folds in the fix. Thanks for the advice. I'll be sure to do that in the future. Dinh > > Regards, > Mike > >> clk: socfpga: Remove socfpga_init_clocks >> >> Steffen Trumtrar (4): >> clk: socfpga: remove unused field >> clk: socfpga: fix define typo >> clk: socfpga: fix compile error >> clk: socfpga: split clk code >> >> arch/arm/mach-socfpga/socfpga.c | 5 - >> drivers/clk/socfpga/Makefile | 3 + >> drivers/clk/socfpga/clk-gate.c | 223 ++++++++++++++++++++++++++ >> drivers/clk/socfpga/clk-periph.c | 94 +++++++++++ >> drivers/clk/socfpga/clk-pll.c | 111 +++++++++++++ >> drivers/clk/socfpga/clk.c | 328 ++------------------------------------ >> drivers/clk/socfpga/clk.h | 57 +++++++ >> 7 files changed, 500 insertions(+), 321 deletions(-) >> create mode 100644 drivers/clk/socfpga/clk-gate.c >> create mode 100644 drivers/clk/socfpga/clk-periph.c >> create mode 100644 drivers/clk/socfpga/clk-pll.c >> create mode 100644 drivers/clk/socfpga/clk.h >>
Hi Mike, Please pull in these patches that cleans up the SOCFPGA clock driver. This is V2 of the pull request that includes 4 patches from Steffen Trumtrar. Thanks, Dinh The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae: Linux 3.13-rc1 (2013-11-22 11:30:55 -0800) are available in the git repository at: git://git.rocketboards.org/linux-socfpga-next.git tags/socfpga-clk-for-3.14_v2 for you to fetch changes up to d5387681665e58bafc1a9c745182f03aab0579c3: clk: socfpga: split clk code (2014-01-06 11:22:22 -0600) ---------------------------------------------------------------- v2: SOCFPGA clk cleanups for 3.14 ---------------------------------------------------------------- Dinh Nguyen (3): clk: socfpga: Map the clk manager base address in the clock driver clk: socfpga: Look for the GPIO_DB_CLK by its offset clk: socfpga: Remove socfpga_init_clocks Steffen Trumtrar (4): clk: socfpga: remove unused field clk: socfpga: fix define typo clk: socfpga: fix compile error clk: socfpga: split clk code arch/arm/mach-socfpga/socfpga.c | 5 - drivers/clk/socfpga/Makefile | 3 + drivers/clk/socfpga/clk-gate.c | 223 ++++++++++++++++++++++++++ drivers/clk/socfpga/clk-periph.c | 94 +++++++++++ drivers/clk/socfpga/clk-pll.c | 111 +++++++++++++ drivers/clk/socfpga/clk.c | 328 ++------------------------------------ drivers/clk/socfpga/clk.h | 57 +++++++ 7 files changed, 500 insertions(+), 321 deletions(-) create mode 100644 drivers/clk/socfpga/clk-gate.c create mode 100644 drivers/clk/socfpga/clk-periph.c create mode 100644 drivers/clk/socfpga/clk-pll.c create mode 100644 drivers/clk/socfpga/clk.h