| Message ID | 1351005779-30347-4-git-send-email-shawn.guo@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 23.10.2012 17:22, Shawn Guo wrote: > ARM core r2p10 and PL310 r3p2 are integrated on imx6q. Select > corresponding errata. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > arch/arm/mach-imx/Kconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > index 4f73866..3ce2771 100644 > --- a/arch/arm/mach-imx/Kconfig > +++ b/arch/arm/mach-imx/Kconfig ... > @@ -843,6 +848,9 @@ config SOC_IMX6Q > select MFD_SYSCON > select PINCTRL > select PINCTRL_IMX6Q > + select PL310_ERRATA_588369 if CACHE_PL310 > + select PL310_ERRATA_727915 if CACHE_PL310 > + select PL310_ERRATA_769419 if CACHE_PL310 > select PM_OPP if PM Just a question: To my understanding, the PL310 on i.MX6D/Q is r3p1-50rel0 and on i.MX6DL/SOLO/SL is r3p2. The PL310 errata I've (Document Revision: 12.1, 14-Apr-2011) states that 588369 and 727915 don't apply to the PL310 revisions r3p1-50rel0/r3p2. So I would think that we don't have to select them for SOC_IMX6Q. Have I missed anything? Best regards Dirk
On Thu, Nov 28, 2013 at 01:44:16PM +0100, Dirk Behme wrote: > On 23.10.2012 17:22, Shawn Guo wrote: > >ARM core r2p10 and PL310 r3p2 are integrated on imx6q. Select > >corresponding errata. > > > >Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > >--- > > arch/arm/mach-imx/Kconfig | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > >diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > >index 4f73866..3ce2771 100644 > >--- a/arch/arm/mach-imx/Kconfig > >+++ b/arch/arm/mach-imx/Kconfig > ... > >@@ -843,6 +848,9 @@ config SOC_IMX6Q > > select MFD_SYSCON > > select PINCTRL > > select PINCTRL_IMX6Q > >+ select PL310_ERRATA_588369 if CACHE_PL310 > >+ select PL310_ERRATA_727915 if CACHE_PL310 > >+ select PL310_ERRATA_769419 if CACHE_PL310 > > select PM_OPP if PM > > Just a question: To my understanding, the PL310 on i.MX6D/Q is > r3p1-50rel0 and on i.MX6DL/SOLO/SL is r3p2. > > The PL310 errata I've (Document Revision: 12.1, 14-Apr-2011) states > that 588369 and 727915 don't apply to the PL310 revisions > r3p1-50rel0/r3p2. So I would think that we don't have to select them > for SOC_IMX6Q. > > Have I missed anything? Hmm, I have forgot the exact reason why I selected these, probably because the help text of the errata Kconfig options do not specify any particular revision that is affected. If a formal PL310 errata document suggests so, we should probably just drop the items (with some testing to ensure no regression is caused). BTW, is the PL310 errata publicly available somewhere? Shawn
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index 4f73866..3ce2771 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -832,6 +832,11 @@ config SOC_IMX6Q select ARCH_HAS_CPUFREQ select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM + select ARM_ERRATA_743622 + select ARM_ERRATA_751472 + select ARM_ERRATA_754322 + select ARM_ERRATA_764369 if SMP + select ARM_ERRATA_775420 select ARM_GIC select COMMON_CLK select CPU_V7 @@ -843,6 +848,9 @@ config SOC_IMX6Q select MFD_SYSCON select PINCTRL select PINCTRL_IMX6Q + select PL310_ERRATA_588369 if CACHE_PL310 + select PL310_ERRATA_727915 if CACHE_PL310 + select PL310_ERRATA_769419 if CACHE_PL310 select PM_OPP if PM help
ARM core r2p10 and PL310 r3p2 are integrated on imx6q. Select corresponding errata. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- arch/arm/mach-imx/Kconfig | 8 ++++++++ 1 file changed, 8 insertions(+)