mbox series

[RFC,0/4] split rk3568 and rk3566 device trees

Message ID 20210710151034.32857-1-pgwipeout@gmail.com
Headers show
Series split rk3568 and rk3566 device trees | expand

Message

Peter Geis July 10, 2021, 3:10 p.m. UTC 
This is an example patch set that addresses the split of the rk3568 and
rk3566 soc device trees.
This method attempts to avoid deleting and modifing nodes by maintaining
a common dtsi for all common items and adding in the differences in
separate dtsi files.
It also includes a basic dts for the Pine64 Quartz64 Model A board
as an example of a rk3566 device.

This series has the following prerequisite:
arm64: dts: rockchip: add pmu and qos nodes for rk3568
https://patchwork.kernel.org/project/linux-rockchip/patch/20210624114719.1685-4-cl@rock-chips.com/

Peter Geis (4):
  arm64: dts: rockchip: move rk3568 dtsi to rk356x dtsi
  arm64: dts: rockchip: split rk3568 device tree
  arm64: dts: rockchip: add rk3566 dtsi
  arm64: dts: rockchip: add basic dts for Pine64 Quartz64-A

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 321 +++++++
 arch/arm64/boot/dts/rockchip/rk3566.dtsi      |  20 +
 arch/arm64/boot/dts/rockchip/rk3568.dtsi      | 814 +-----------------
 arch/arm64/boot/dts/rockchip/rk356x.dtsi      | 786 +++++++++++++++++
 6 files changed, 1153 insertions(+), 794 deletions(-)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566.dtsi
 create mode 100644 arch/arm64/boot/dts/rockchip/rk356x.dtsi

Comments

Rob Herring (Arm) July 15, 2021, 4:21 p.m. UTC | #1 
On Sat, 10 Jul 2021 11:10:34 -0400, Peter Geis wrote:
> Add a basic dts for the Pine64 Quartz64 Model A Single Board Computer.
> This board outputs on uart2 for debug.
> 
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> ---
>  .../devicetree/bindings/arm/rockchip.yaml     |   5 +
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 321 ++++++++++++++++++
>  3 files changed, 327 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> 

Acked-by: Rob Herring <robh@kernel.org>
Peter Geis July 20, 2021, 4:19 p.m. UTC | #2 
On Thu, Jul 15, 2021 at 12:21 PM Rob Herring <robh@kernel.org> wrote:
>
> On Sat, 10 Jul 2021 11:10:34 -0400, Peter Geis wrote:
> > Add a basic dts for the Pine64 Quartz64 Model A Single Board Computer.
> > This board outputs on uart2 for debug.
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> >  .../devicetree/bindings/arm/rockchip.yaml     |   5 +
> >  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
> >  .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 321 ++++++++++++++++++
> >  3 files changed, 327 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> >
>
> Acked-by: Rob Herring <robh@kernel.org>

Thank you!
I need to split the dt-bindings out into a separate patch, and the
quartz64-a dts has some mild changes.
Are you okay with me using your ack still?
Heiko Stuebner July 23, 2021, 12:02 p.m. UTC | #3 
On Sat, 10 Jul 2021 11:10:30 -0400, Peter Geis wrote:
> This is an example patch set that addresses the split of the rk3568 and
> rk3566 soc device trees.
> This method attempts to avoid deleting and modifing nodes by maintaining
> a common dtsi for all common items and adding in the differences in
> separate dtsi files.
> It also includes a basic dts for the Pine64 Quartz64 Model A board
> as an example of a rk3566 device.
> 
> [...]

Applied, thanks!

[1/4] arm64: dts: rockchip: move rk3568 dtsi to rk356x dtsi
      commit: 94c75b5265fe899391e298eace826e4f8d1e8e40
[2/4] arm64: dts: rockchip: split rk3568 device tree
      commit: 92eb5ffbae440700dd38378e24d8091fe166c352
[3/4] arm64: dts: rockchip: add rk3566 dtsi
      commit: 04e1ecf6099cc3ba17c2d4279c968a656320cd12
[4/4] arm64: dts: rockchip: add basic dts for Pine64 Quartz64-A
      commit: c95414d68f116462acf9622f715b8a568bb1dd00

Best regards,
Rob Herring (Arm) July 28, 2021, 5:25 p.m. UTC | #4 
On Tue, Jul 20, 2021 at 10:19 AM Peter Geis <pgwipeout@gmail.com> wrote:
>
> On Thu, Jul 15, 2021 at 12:21 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Sat, 10 Jul 2021 11:10:34 -0400, Peter Geis wrote:
> > > Add a basic dts for the Pine64 Quartz64 Model A Single Board Computer.
> > > This board outputs on uart2 for debug.
> > >
> > > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > > ---
> > >  .../devicetree/bindings/arm/rockchip.yaml     |   5 +
> > >  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
> > >  .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 321 ++++++++++++++++++
> > >  3 files changed, 327 insertions(+)
> > >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > >
> >
> > Acked-by: Rob Herring <robh@kernel.org>
>
> Thank you!
> I need to split the dt-bindings out into a separate patch, and the
> quartz64-a dts has some mild changes.
> Are you okay with me using your ack still?

Yes.

Rob