| Message ID | c34db7fdcd7ac86046fe481cb91a9a48@208suo.com |
|---|---|
| State | New |
| Headers | show |
| Series | drivers: ata: Added missing spaces | expand |
You should CC me on the PATA patches. And your subject should look like this: ata: pata_triflex: Added missing spaces On 7/18/23 12:12 PM, hanyu001@208suo.com wrote: > Added spaces needed in the proper places to address: > > ./drivers/ata/pata_triflex.c:88: ERROR: space required after that ';' (ctx:VxV) > ./drivers/ata/pata_triflex.c:90: ERROR: space required after that ';' (ctx:VxV) > ./drivers/ata/pata_triflex.c:92: ERROR: space required after that ';' (ctx:VxV) > ./drivers/ata/pata_triflex.c:96: ERROR: space required after that ';' (ctx:VxV) > ./drivers/ata/pata_triflex.c:98: ERROR: space required after that ';' (ctx:VxV) > ./drivers/ata/pata_triflex.c:100: ERROR: space required after that ';' (ctx:VxV) > ./drivers/ata/pata_triflex.c:102: ERROR: space required after that ';' (ctx:VxV) > ./drivers/ata/pata_triflex.c:104: ERROR: space required after that ';' (ctx:VxV) > ./drivers/ata/pata_triflex.c:106: ERROR: space required after that ';' (ctx:VxV) > > Signed-off-by: Yu Han <hanyu001@208suo.com> Aside from the issue with the subject: Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> MBR, Sergey
diff --git a/drivers/ata/pata_triflex.c b/drivers/ata/pata_triflex.c index 26d448a..e75bf93 100644 --- a/drivers/ata/pata_triflex.c +++ b/drivers/ata/pata_triflex.c @@ -85,25 +85,25 @@ static void triflex_load_timing(struct ata_port *ap, struct ata_device *adev, in switch(speed) { case XFER_MW_DMA_2: - timing = 0x0103;break; + timing = 0x0103; break; case XFER_MW_DMA_1: - timing = 0x0203;break; + timing = 0x0203; break; case XFER_MW_DMA_0: - timing = 0x0808;break; + timing = 0x0808; break; case XFER_SW_DMA_2: case XFER_SW_DMA_1: case XFER_SW_DMA_0: - timing = 0x0F0F;break; + timing = 0x0F0F; break; case XFER_PIO_4: - timing = 0x0202;break; + timing = 0x0202; break; case XFER_PIO_3: - timing = 0x0204;break; + timing = 0x0204; break; case XFER_PIO_2: - timing = 0x0404;break; + timing = 0x0404; break; case XFER_PIO_1: - timing = 0x0508;break; + timing = 0x0508; break; case XFER_PIO_0: - timing = 0x0808;break; + timing = 0x0808; break; default: BUG();
Added spaces needed in the proper places to address: ./drivers/ata/pata_triflex.c:88: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_triflex.c:90: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_triflex.c:92: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_triflex.c:96: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_triflex.c:98: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_triflex.c:100: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_triflex.c:102: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_triflex.c:104: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_triflex.c:106: ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Yu Han <hanyu001@208suo.com> --- drivers/ata/pata_triflex.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) }