diff mbox series

sata_gemini: Use devm_platform_ioremap_resource() in gemini_sata_probe()

Message ID b17404cd-294f-fe2f-e8a3-2218a0dae14f@web.de
State Not Applicable
Delegated to: David Miller
Headers show
Series sata_gemini: Use devm_platform_ioremap_resource() in gemini_sata_probe() | expand

Commit Message

Markus Elfring Sept. 18, 2019, 6:34 a.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 18 Sep 2019 08:28:09 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/ata/sata_gemini.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

--
2.23.0

Comments

Linus Walleij Oct. 4, 2019, 7:44 p.m. UTC | #1 
On Wed, Sep 18, 2019 at 8:34 AM Markus Elfring <Markus.Elfring@web.de> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 18 Sep 2019 08:28:09 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Looks correct.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
index f793564f3d78..61a34cad90c1 100644
--- a/drivers/ata/sata_gemini.c
+++ b/drivers/ata/sata_gemini.c
@@ -318,7 +318,6 @@  static int gemini_sata_probe(struct platform_device *pdev)
 	struct device_node *np = dev->of_node;
 	struct sata_gemini *sg;
 	struct regmap *map;
-	struct resource *res;
 	enum gemini_muxmode muxmode;
 	u32 gmode;
 	u32 gmask;
@@ -328,12 +327,7 @@  static int gemini_sata_probe(struct platform_device *pdev)
 	if (!sg)
 		return -ENOMEM;
 	sg->dev = dev;
-
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENODEV;
-
-	sg->base = devm_ioremap_resource(dev, res);
+	sg->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(sg->base))
 		return PTR_ERR(sg->base);