From patchwork Thu Nov 21 03:07:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 292946 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DF4182C0146 for ; Thu, 21 Nov 2013 14:07:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751613Ab3KUDHL (ORCPT ); Wed, 20 Nov 2013 22:07:11 -0500 Received: from mail-bk0-f52.google.com ([209.85.214.52]:51283 "EHLO mail-bk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860Ab3KUDHL (ORCPT ); Wed, 20 Nov 2013 22:07:11 -0500 Received: by mail-bk0-f52.google.com with SMTP id u14so100508bkz.11 for ; Wed, 20 Nov 2013 19:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=IojIWxv4wRu78bsNLClg4v9hxAZyN803rFizNfHWosk=; b=DEVbNsSicZkOhz5q5i07ggI6eUaiK77d1+FSZlGwRVjAQj8eqYcuuFR8X/n3b8OeJf cTGKDfElcGBROq9lElgBUFLi2csnkb9dx95SLEEmLVXZtNNwdFK8mtq7Pjha5+DC6j6n GAZjFWTVhwXV1d0L8jvS983+gD7fx6/tUcsFonewHgF9wYRq6PWdUwc5k0LXPcmSkYjj Bxt+w7lAVJa0U5GlNxKrcy3hz+UOWclJdZ0i9WvTsDRNSU5+2s1R0K7h3GsawuNn0/YP SO2RsH5xpyw+TP3xT+8Y6c0e5/lO1prkjm1Zo6vhpxBsnqJ26X2G0oEVODGZjy8qgdun Ol2g== MIME-Version: 1.0 X-Received: by 10.204.203.12 with SMTP id fg12mr213413bkb.31.1385003229693; Wed, 20 Nov 2013 19:07:09 -0800 (PST) Received: by 10.204.74.130 with HTTP; Wed, 20 Nov 2013 19:07:09 -0800 (PST) Date: Thu, 21 Nov 2013 11:07:09 +0800 Message-ID: Subject: [PATCH -next] pata_arasan_cf: add missing clk_disable_unprepare() on error path From: Wei Yongjun To: viresh.linux@gmail.com, tj@kernel.org, grant.likely@linaro.org, rob.herring@calxeda.com Cc: yongjun_wei@trendmicro.com.cn, linux-ide@vger.kernel.org Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Wei Yongjun Add the missing clk_disable_unprepare() before return from cf_init() in the error handling case. Signed-off-by: Wei Yongjun Acked-by: Viresh Kumar --- drivers/ata/pata_arasan_cf.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c index e88690e..73492dd 100644 --- a/drivers/ata/pata_arasan_cf.c +++ b/drivers/ata/pata_arasan_cf.c @@ -319,6 +319,7 @@ static int cf_init(struct arasan_cf_dev *acdev) ret = clk_set_rate(acdev->clk, 166000000); if (ret) { dev_warn(acdev->host->dev, "clock set rate failed"); + clk_disable_unprepare(acdev->clk); return ret; }