diff mbox series

ata_piix: Fix uninitialized use in piix_check_450nx_errata()

Message ID CABvMjLQY0RaprCf0TUNpQSY2wsDOp0sZNkkWShm_+c+VeM-4=A@mail.gmail.com
State New
Headers show
Series ata_piix: Fix uninitialized use in piix_check_450nx_errata() | expand

Commit Message

Yizhuo Zhai April 19, 2021, 4:44 p.m. UTC 
Inside function piix_check_450nx_errata(), variable "cfg" could be
uninitialized if pci_bus_read_config_word() returns
PCIBIOS_BAD_REGISTER_NUMBER. However, it is directly used in if
statement, which is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/ata/ata_piix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

PCI_DEVICE_ID_INTEL_82454NX, pdev)) != NULL) {
diff mbox series

Patch

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 3ca7720e7d8f..0acc1ba9eae2 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -1309,7 +1309,7 @@  static int piix_disable_ahci(struct pci_dev *pdev)
 static int piix_check_450nx_errata(struct pci_dev *ata_dev)
 {
        struct pci_dev *pdev = NULL;
-       u16 cfg;
+       u16 cfg = ~0;
        int no_piix_dma = 0;

        while ((pdev = pci_get_device(PCI_VENDOR_ID_INTEL,