diff mbox

libata-scsi: set correct VERSION field for ZAC devices

Message ID 5784f482.d607620a.24b2e.ffffae8e@mx.google.com
State Not Applicable
Delegated to: David Miller
Headers show

Commit Message

Tom Yan July 12, 2016, 1:45 p.m. UTC 
From: Tom Yan <tom.ty89@gmail.com>

Commit 856c4663930988118d9f355aad66811dd6df06de had the line that
"bumps" the VERSION field in standard INQUIRY data removed. Add
it back and claim SPC-5 version compatibility, which matches with
the current version descriptor "SPC-5 (no version claimed)" used
for ZAC devices.

Signed-off-by: Tom Yan <tom.ty89@gmail.com>

Comments

Sergei Shtylyov July 12, 2016, 1:58 p.m. UTC | #1 
On 7/12/2016 4:45 PM, tom.ty89@gmail.com wrote:

> From: Tom Yan <tom.ty89@gmail.com>
>
> Commit 856c4663930988118d9f355aad66811dd6df06de had the line that

    You also need to specify the commit summary in (""). It's enough to 
specify 12 digits of SHA1 ID.

> "bumps" the VERSION field in standard INQUIRY data removed. Add
> it back and claim SPC-5 version compatibility, which matches with
> the current version descriptor "SPC-5 (no version claimed)" used
> for ZAC devices.
>
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index bfec66f..27e29e1 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2109,8 +2109,10 @@  static unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf)
 	    (args->dev->link->ap->pflags & ATA_PFLAG_EXTERNAL))
 		hdr[1] |= (1 << 7);
 
-	if (args->dev->class == ATA_DEV_ZAC)
+	if (args->dev->class == ATA_DEV_ZAC) {
 		hdr[0] = TYPE_ZBC;
+		hdr[2] = 0x7; /* claim SPC-5 version compatibility */
+	}
 
 	memcpy(rbuf, hdr, sizeof(hdr));
 	memcpy(&rbuf[8], "ATA     ", 8);