From patchwork Mon Jan 12 23:05:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriele Mazzotta X-Patchwork-Id: 428180 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CD50414008F for ; Tue, 13 Jan 2015 10:05:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753265AbbALXFH (ORCPT ); Mon, 12 Jan 2015 18:05:07 -0500 Received: from mail-wg0-f46.google.com ([74.125.82.46]:41980 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258AbbALXFE (ORCPT ); Mon, 12 Jan 2015 18:05:04 -0500 Received: by mail-wg0-f46.google.com with SMTP id x13so22106381wgg.5; Mon, 12 Jan 2015 15:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; bh=kE0E8g3ShsehyKwNarCepavQFbhPgYxXRzYQQur8n0E=; b=Bgrm6Wz2Rs8iXcEG987y+RSF9YWx9O7nkvAMtpj61cZdeDgH+yFbC0t3EYqGNGW97k 7DX8xB3ANCpUNZfoWyKMJYq6rYqYjFas2zBklyRsJPdv5WBeBoA6sYmabJa+ooVTwNKZ H1zw4lVTYFih7cB5F6hT4ZzMdN8bhPcYabYde1Wt5fcy1LByq3q109Nx7hwYCBezO6mQ msNdjYKzz2BVw4MNFBXPauzDkPluQUfKfOohxQnJ0nynRROdNeic8VPmDGoRwHzZTZ7c 6iwePGIFKBsliKMyhZalnJrVFfnCiMsmexYU2IV2cXNbRV59jovTnPlY4jsA2m4np4EI Y+zg== X-Received: by 10.180.72.177 with SMTP id e17mr34209225wiv.42.1421103902721; Mon, 12 Jan 2015 15:05:02 -0800 (PST) Received: from hostprova (2-235-140-64.ip228.fastwebnet.it. [2.235.140.64]) by mx.google.com with ESMTPSA id r3sm11959259wic.10.2015.01.12.15.05.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jan 2015 15:05:01 -0800 (PST) Date: Mon, 12 Jan 2015 15:05:01 -0800 (PST) X-Google-Original-Date: Tue, 13 Jan 2015 00:05 +0100 From: Gabriele Mazzotta To: linux-kernel@vger.kernel.org Cc: linux-ide@vger.kernel.org, tj@kernel.org, stripathi@apm.com Subject: Re: SATA link power management issues Message-ID: <2526428.uJaEqCTeIa@xps13> In-Reply-To: <3352987.ugV1Ipy7Z5@xps13> References: <3352987.ugV1Ipy7Z5@xps13> MIME-Version: 1.0 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org I just tried the following and I no longer get errors: I haven't read the specification, so this might be bad. I did this in base of some consideration I made that, as far as I know, could be completely wrong. I hope you can get something meaningful out of this. Gabriele --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 97683e4..c815b31 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1708,10 +1708,10 @@ static void ahci_handle_port_interrupt(struct ata_port *ap, status &= ~PORT_IRQ_BAD_PMP; /* if LPM is enabled, PHYRDY doesn't mean anything */ - if (ap->link.lpm_policy > ATA_LPM_MAX_POWER) { +// if (ap->link.lpm_policy > ATA_LPM_MAX_POWER) { status &= ~PORT_IRQ_PHYRDY; ahci_scr_write(&ap->link, SCR_ERROR, SERR_PHYRDY_CHG); - } +// } if (unlikely(status & PORT_IRQ_ERROR)) { ahci_error_intr(ap, status);