| Message ID | 20240403043349.3623961-1-nichen@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] ata: sata_gemini: Add check for clk_enable | expand |
On 4/3/24 13:33, Chen Ni wrote: > The call to clk_enable() in gemini_sata_start_bridge() can fail. > Add a check to detect such failure. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Applied to for-6.9-fixes. Thanks !
diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c index 400b22ee99c3..4c270999ba3c 100644 --- a/drivers/ata/sata_gemini.c +++ b/drivers/ata/sata_gemini.c @@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge) pclk = sg->sata0_pclk; else pclk = sg->sata1_pclk; - clk_enable(pclk); + ret = clk_enable(pclk); + if (ret) + return ret; + msleep(10); /* Do not keep clocking a bridge that is not online */
The call to clk_enable() in gemini_sata_start_bridge() can fail. Add a check to detect such failure. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- Changelog: v1 -> v2: 1. Simplify commit message --- drivers/ata/sata_gemini.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)