| Message ID | 20240123183002.15499-1-conikost@gentoo.org |
|---|---|
| State | New |
| Headers | show |
| Series | ahci: asm1166: correct count of reported ports | expand |
Hi, On 1/23/24 19:30, Conrad Kostecki wrote: > The ASM1166 SATA host controller always reports wrongly, > that it has 32 ports. But in reality, it only has six ports. > > This seems to be a hardware issue, as all tested ASM1166 > SATA host controllers reports such high count of ports. > > Example output: ahci 0000:09:00.0: AHCI 0001.0301 > 32 slots 32 ports 6 Gbps 0xffffff3f impl SATA mode. > > By adjusting the port_map, the count is limited to six ports. > > New output: ahci 0000:09:00.0: AHCI 0001.0301 > 32 slots 32 ports 6 Gbps 0x3f impl SATA mode. > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=211873 > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218346 > Signed-off-by: Conrad Kostecki <conikost@gentoo.org> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/ata/ahci.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 3a5f3255f51b..762c5d8b7c1a 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -663,6 +663,11 @@ MODULE_PARM_DESC(mobile_lpm_policy, "Default LPM policy for mobile chipsets"); > static void ahci_pci_save_initial_config(struct pci_dev *pdev, > struct ahci_host_priv *hpriv) > { > + if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && pdev->device == 0x1166) { > + dev_info(&pdev->dev, "ASM1166 has only six ports\n"); > + hpriv->saved_port_map = 0x3f; > + } > + > if (pdev->vendor == PCI_VENDOR_ID_JMICRON && pdev->device == 0x2361) { > dev_info(&pdev->dev, "JMB361 has only one port\n"); > hpriv->saved_port_map = 1;
Hi Conrad, On 1/23/24 19:30, Conrad Kostecki wrote: > The ASM1166 SATA host controller always reports wrongly, > that it has 32 ports. But in reality, it only has six ports. > > This seems to be a hardware issue, as all tested ASM1166 > SATA host controllers reports such high count of ports. > > Example output: ahci 0000:09:00.0: AHCI 0001.0301 > 32 slots 32 ports 6 Gbps 0xffffff3f impl SATA mode. > > By adjusting the port_map, the count is limited to six ports. > > New output: ahci 0000:09:00.0: AHCI 0001.0301 > 32 slots 32 ports 6 Gbps 0x3f impl SATA mode. > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=211873 > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218346 > Signed-off-by: Conrad Kostecki <conikost@gentoo.org> Looks like this is a double submission of the earlier version (which did make it to the list). Anyways this version looks good to me too: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/ata/ahci.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 3a5f3255f51b..762c5d8b7c1a 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -663,6 +663,11 @@ MODULE_PARM_DESC(mobile_lpm_policy, "Default LPM policy for mobile chipsets"); > static void ahci_pci_save_initial_config(struct pci_dev *pdev, > struct ahci_host_priv *hpriv) > { > + if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && pdev->device == 0x1166) { > + dev_info(&pdev->dev, "ASM1166 has only six ports\n"); > + hpriv->saved_port_map = 0x3f; > + } > + > if (pdev->vendor == PCI_VENDOR_ID_JMICRON && pdev->device == 0x2361) { > dev_info(&pdev->dev, "JMB361 has only one port\n"); > hpriv->saved_port_map = 1;
On Tue, Jan 23, 2024 at 07:30:02PM +0100, Conrad Kostecki wrote: > The ASM1166 SATA host controller always reports wrongly, > that it has 32 ports. But in reality, it only has six ports. > > This seems to be a hardware issue, as all tested ASM1166 > SATA host controllers reports such high count of ports. > > Example output: ahci 0000:09:00.0: AHCI 0001.0301 > 32 slots 32 ports 6 Gbps 0xffffff3f impl SATA mode. > > By adjusting the port_map, the count is limited to six ports. > > New output: ahci 0000:09:00.0: AHCI 0001.0301 > 32 slots 32 ports 6 Gbps 0x3f impl SATA mode. > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=211873 > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218346 > Signed-off-by: Conrad Kostecki <conikost@gentoo.org> > --- Applied: https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-6.8-fixes
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 3a5f3255f51b..762c5d8b7c1a 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -663,6 +663,11 @@ MODULE_PARM_DESC(mobile_lpm_policy, "Default LPM policy for mobile chipsets"); static void ahci_pci_save_initial_config(struct pci_dev *pdev, struct ahci_host_priv *hpriv) { + if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && pdev->device == 0x1166) { + dev_info(&pdev->dev, "ASM1166 has only six ports\n"); + hpriv->saved_port_map = 0x3f; + } + if (pdev->vendor == PCI_VENDOR_ID_JMICRON && pdev->device == 0x2361) { dev_info(&pdev->dev, "JMB361 has only one port\n"); hpriv->saved_port_map = 1;
The ASM1166 SATA host controller always reports wrongly, that it has 32 ports. But in reality, it only has six ports. This seems to be a hardware issue, as all tested ASM1166 SATA host controllers reports such high count of ports. Example output: ahci 0000:09:00.0: AHCI 0001.0301 32 slots 32 ports 6 Gbps 0xffffff3f impl SATA mode. By adjusting the port_map, the count is limited to six ports. New output: ahci 0000:09:00.0: AHCI 0001.0301 32 slots 32 ports 6 Gbps 0x3f impl SATA mode. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=211873 Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218346 Signed-off-by: Conrad Kostecki <conikost@gentoo.org> --- drivers/ata/ahci.c | 5 +++++ 1 file changed, 5 insertions(+)