| Message ID | 20240111115123.1258422-2-dlemoal@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | Power management fixes | expand |
On Thu, Jan 11, 2024 at 08:51:22PM +0900, Damien Le Moal wrote: > In ata ata_dev_power_set_standby(), check that the target device is not > sleeping. If it is, there is no need to do anything. > > Fixes: aa3998dbeb3a ("ata: libata-scsi: Disable scsi device manage_system_start_stop") > Cc: stable@vger.kernel.org > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > drivers/ata/libata-core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 09ed67772fae..d9f80f4f70f5 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -2017,6 +2017,10 @@ void ata_dev_power_set_standby(struct ata_device *dev) > struct ata_taskfile tf; > unsigned int err_mask; > > + /* If the device is already sleeping, do nothing. */ > + if (dev->flags & ATA_DFLAG_SLEEPING) > + return; > + > /* > * Some odd clown BIOSes issue spindown on power off (ACPI S4 or S5) > * causing some drives to spin up and down again. For these, do nothing > -- > 2.43.0 > Holding off [PATCH 2/2] until we get a better understanding of things, thus for [PATCH 1/2] only: Applied: https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-6.8-fixes
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 09ed67772fae..d9f80f4f70f5 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2017,6 +2017,10 @@ void ata_dev_power_set_standby(struct ata_device *dev) struct ata_taskfile tf; unsigned int err_mask; + /* If the device is already sleeping, do nothing. */ + if (dev->flags & ATA_DFLAG_SLEEPING) + return; + /* * Some odd clown BIOSes issue spindown on power off (ACPI S4 or S5) * causing some drives to spin up and down again. For these, do nothing
In ata ata_dev_power_set_standby(), check that the target device is not sleeping. If it is, there is no need to do anything. Fixes: aa3998dbeb3a ("ata: libata-scsi: Disable scsi device manage_system_start_stop") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/ata/libata-core.c | 4 ++++ 1 file changed, 4 insertions(+)