| Message ID | 20240111111512.1255875-1-dlemoal@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | ata: libata-core: Do not try to set sleeping devices to standby | expand |
On 1/11/24 20:15, Damien Le Moal wrote: > In ata ata_dev_power_set_standby(), check that the target device is not > sleeping. If it is, there is no need to do anything. > > Fixes: aa3998dbeb3a ("ata: libata-scsi: Disable scsi device manage_system_start_stop") > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Forgot to add Cc: stable. Resending. > --- > drivers/ata/libata-core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 09ed67772fae..d9f80f4f70f5 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -2017,6 +2017,10 @@ void ata_dev_power_set_standby(struct ata_device *dev) > struct ata_taskfile tf; > unsigned int err_mask; > > + /* If the device is already sleeping, do nothing. */ > + if (dev->flags & ATA_DFLAG_SLEEPING) > + return; > + > /* > * Some odd clown BIOSes issue spindown on power off (ACPI S4 or S5) > * causing some drives to spin up and down again. For these, do nothing
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 09ed67772fae..d9f80f4f70f5 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2017,6 +2017,10 @@ void ata_dev_power_set_standby(struct ata_device *dev) struct ata_taskfile tf; unsigned int err_mask; + /* If the device is already sleeping, do nothing. */ + if (dev->flags & ATA_DFLAG_SLEEPING) + return; + /* * Some odd clown BIOSes issue spindown on power off (ACPI S4 or S5) * causing some drives to spin up and down again. For these, do nothing
In ata ata_dev_power_set_standby(), check that the target device is not sleeping. If it is, there is no need to do anything. Fixes: aa3998dbeb3a ("ata: libata-scsi: Disable scsi device manage_system_start_stop") Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/ata/libata-core.c | 4 ++++ 1 file changed, 4 insertions(+)