| Message ID | 20231005192440.4047-2-linux@zary.sk |
|---|---|
| State | New |
| Headers | show |
| Series | ata: pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable | expand |
On 10/5/23 10:24 PM, Ondrej Zary wrote: > There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the > detection to always fail. Fix it. > > Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") > Cc: stable@vger.kernel.org > Signed-off-by: Ondrej Zary <linux@zary.sk> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
On 10/5/23 10:41 PM, Sergei Shtylyov wrote: [...] >> There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the >> detection to always fail. Fix it. >> >> Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") >> Cc: stable@vger.kernel.org >> Signed-off-by: Ondrej Zary <linux@zary.sk> > > Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> Oops, replied from a wrong account... :-/ > [...] MBR, Sergey
diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 1af64d435d3c..258d189f42e5 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55); - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055); + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa); nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT);
There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the detection to always fail. Fix it. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Zary <linux@zary.sk> --- drivers/ata/pata_parport/pata_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)