diff mbox series

[v2] ata: pata_ns87415: mark ns87560_tf_read static

Message ID 20230726203354.946631-1-arnd@kernel.org
State New
Headers show
Series [v2] ata: pata_ns87415: mark ns87560_tf_read static | expand

Commit Message

Arnd Bergmann July 26, 2023, 8:33 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The global function triggers a warning because of the missing prototype

drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
  263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)

There are no other references to this, so just make it static.

Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: fix changelog text
---
 drivers/ata/pata_ns87415.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Damien Le Moal July 26, 2023, 11:45 p.m. UTC | #1 
On 7/27/23 05:33, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The global function triggers a warning because of the missing prototype
> 
> drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
>   263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
> 
> There are no other references to this, so just make it static.
> 
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to for-6.5-fixes. Thanks !
diff mbox series

Patch

diff --git a/drivers/ata/pata_ns87415.c b/drivers/ata/pata_ns87415.c
index d60e1f69d7b02..c697219a61a2d 100644
--- a/drivers/ata/pata_ns87415.c
+++ b/drivers/ata/pata_ns87415.c
@@ -260,7 +260,7 @@  static u8 ns87560_check_status(struct ata_port *ap)
  *	LOCKING:
  *	Inherited from caller.
  */
-void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
 {
 	struct ata_ioports *ioaddr = &ap->ioaddr;