diff mbox series

[1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT

Message ID 20230323033836.352672-2-damien.lemoal@opensource.wdc.com
State New
Headers show
Series Fixes for pata parport bpck6 protocol driver | expand

Commit Message

Damien Le Moal March 23, 2023, 3:38 a.m. UTC
There is no reason to have compilation of the bpck6 protocol module
being dependent on 64BIT. Remove this dependency.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/pata_parport/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ondrej Zary March 23, 2023, 9:01 p.m. UTC | #1
On Thursday 23 March 2023 04:38:35 Damien Le Moal wrote:
> There is no reason to have compilation of the bpck6 protocol module
> being dependent on 64BIT. Remove this dependency.

Great, I planned to do this but forgot. Thanks.
 
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
>  drivers/ata/pata_parport/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_parport/Kconfig b/drivers/ata/pata_parport/Kconfig
> index 0893a13e7979..2c953f5d1396 100644
> --- a/drivers/ata/pata_parport/Kconfig
> +++ b/drivers/ata/pata_parport/Kconfig
> @@ -25,7 +25,7 @@ config PATA_PARPORT_BPCK
>  
>  config PATA_PARPORT_BPCK6
>  	tristate "MicroSolutions backpack (Series 6) protocol"
> -	depends on (PATA_PARPORT) && !64BIT
> +	depends on PATA_PARPORT
>  	help
>  	  This option enables support for the Micro Solutions BACKPACK
>  	  parallel port Series 6 IDE protocol.  (Most BACKPACK drives made
Damien Le Moal March 23, 2023, 10:37 p.m. UTC | #2
On 3/24/23 06:01, Ondrej Zary wrote:
> On Thursday 23 March 2023 04:38:35 Damien Le Moal wrote:
>> There is no reason to have compilation of the bpck6 protocol module
>> being dependent on 64BIT. Remove this dependency.
> 
> Great, I planned to do this but forgot. Thanks.

Can you send a reviewed-by ?

>  
>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>> ---
>>  drivers/ata/pata_parport/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/pata_parport/Kconfig b/drivers/ata/pata_parport/Kconfig
>> index 0893a13e7979..2c953f5d1396 100644
>> --- a/drivers/ata/pata_parport/Kconfig
>> +++ b/drivers/ata/pata_parport/Kconfig
>> @@ -25,7 +25,7 @@ config PATA_PARPORT_BPCK
>>  
>>  config PATA_PARPORT_BPCK6
>>  	tristate "MicroSolutions backpack (Series 6) protocol"
>> -	depends on (PATA_PARPORT) && !64BIT
>> +	depends on PATA_PARPORT
>>  	help
>>  	  This option enables support for the Micro Solutions BACKPACK
>>  	  parallel port Series 6 IDE protocol.  (Most BACKPACK drives made
> 
>
Ondrej Zary March 26, 2023, 8:14 p.m. UTC | #3
On Thursday 23 March 2023 04:38:35 Damien Le Moal wrote:
> There is no reason to have compilation of the bpck6 protocol module
> being dependent on 64BIT. Remove this dependency.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Reviewed-by: Ondrej Zary <linux@zary.sk>

> ---
>  drivers/ata/pata_parport/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_parport/Kconfig b/drivers/ata/pata_parport/Kconfig
> index 0893a13e7979..2c953f5d1396 100644
> --- a/drivers/ata/pata_parport/Kconfig
> +++ b/drivers/ata/pata_parport/Kconfig
> @@ -25,7 +25,7 @@ config PATA_PARPORT_BPCK
>  
>  config PATA_PARPORT_BPCK6
>  	tristate "MicroSolutions backpack (Series 6) protocol"
> -	depends on (PATA_PARPORT) && !64BIT
> +	depends on PATA_PARPORT
>  	help
>  	  This option enables support for the Micro Solutions BACKPACK
>  	  parallel port Series 6 IDE protocol.  (Most BACKPACK drives made
diff mbox series

Patch

diff --git a/drivers/ata/pata_parport/Kconfig b/drivers/ata/pata_parport/Kconfig
index 0893a13e7979..2c953f5d1396 100644
--- a/drivers/ata/pata_parport/Kconfig
+++ b/drivers/ata/pata_parport/Kconfig
@@ -25,7 +25,7 @@  config PATA_PARPORT_BPCK
 
 config PATA_PARPORT_BPCK6
 	tristate "MicroSolutions backpack (Series 6) protocol"
-	depends on (PATA_PARPORT) && !64BIT
+	depends on PATA_PARPORT
 	help
 	  This option enables support for the Micro Solutions BACKPACK
 	  parallel port Series 6 IDE protocol.  (Most BACKPACK drives made