| Message ID | 20230213212549.29914-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | ata: pata_octeon_cf: drop kernel-doc notation | expand |
On 2/14/23 06:25, Randy Dunlap wrote: > Fix a slew of kernel-doc warnings in pata_octeon_cf.c by changing > all "/**" comments to "/*" since they are not in kernel-doc format. > > Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/all/202302101722.5O56RClE-lkp@intel.com/ > Cc: David Daney <ddaney@caviumnetworks.com> > Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: linux-ide@vger.kernel.org Applied to for-6.2-fixes. Thanks !
Hello! Hm, why didn't you CC me? On 2/14/23 12:25 AM, Randy Dunlap wrote: > Fix a slew of kernel-doc warnings in pata_octeon_cf.c by changing > all "/**" comments to "/*" since they are not in kernel-doc format. > > Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/all/202302101722.5O56RClE-lkp@intel.com/ > Cc: David Daney <ddaney@caviumnetworks.com> > Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: linux-ide@vger.kernel.org Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
On 2/14/23 11:33 AM, Sergei Shtylyov wrote: > Hello! > > Hm, why didn't you CC me? > > On 2/14/23 12:25 AM, Randy Dunlap wrote: > >> Fix a slew of kernel-doc warnings in pata_octeon_cf.c by changing >> all "/**" comments to "/*" since they are not in kernel-doc format. >> >> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Reported-by: kernel test robot <lkp@intel.com> >> Link: https://lore.kernel.org/all/202302101722.5O56RClE-lkp@intel.com/ >> Cc: David Daney <ddaney@caviumnetworks.com> >> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> >> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >> Cc: linux-ide@vger.kernel.org > > Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> Oops, replied from a wrong account... :-/ Damien, please let me know if you need this fixed... > [...] MBR, Sergey
On 2/14/23 17:35, Sergei Shtylyov wrote: > On 2/14/23 11:33 AM, Sergei Shtylyov wrote: >> Hello! >> >> Hm, why didn't you CC me? >> >> On 2/14/23 12:25 AM, Randy Dunlap wrote: >> >>> Fix a slew of kernel-doc warnings in pata_octeon_cf.c by changing >>> all "/**" comments to "/*" since they are not in kernel-doc format. >>> >>> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).") >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Reported-by: kernel test robot <lkp@intel.com> >>> Link: https://lore.kernel.org/all/202302101722.5O56RClE-lkp@intel.com/ >>> Cc: David Daney <ddaney@caviumnetworks.com> >>> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> >>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >>> Cc: linux-ide@vger.kernel.org >> >> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > Oops, replied from a wrong account... :-/ > Damien, please let me know if you need this fixed... Nope. That is fine. A review is a review :) I can fix it with your usual email if you prefer though.
On 2/14/23 12:27 PM, Damien Le Moal wrote: [...] >>> Hm, why didn't you CC me? >>> >>> On 2/14/23 12:25 AM, Randy Dunlap wrote: >>> >>>> Fix a slew of kernel-doc warnings in pata_octeon_cf.c by changing >>>> all "/**" comments to "/*" since they are not in kernel-doc format. >>>> >>>> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).") >>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>>> Reported-by: kernel test robot <lkp@intel.com> >>>> Link: https://lore.kernel.org/all/202302101722.5O56RClE-lkp@intel.com/ >>>> Cc: David Daney <ddaney@caviumnetworks.com> >>>> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> >>>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >>>> Cc: linux-ide@vger.kernel.org >>> >>> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> >> >> Oops, replied from a wrong account... :-/ >> Damien, please let me know if you need this fixed... > > Nope. That is fine. A review is a review :) > I can fix it with your usual email if you prefer though. Well, the OMP's address is correct and listed in MAINTAINERS. It's the address I replied from that was wrong. Some pepole (like GregKH) want From: and SoB to match... MBR, Sergey
diff -- a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c --- a/drivers/ata/pata_octeon_cf.c +++ b/drivers/ata/pata_octeon_cf.c @@ -67,7 +67,7 @@ module_param(enable_dma, int, 0444); MODULE_PARM_DESC(enable_dma, "Enable use of DMA on interfaces that support it (0=no dma [default], 1=use dma)"); -/** +/* * Convert nanosecond based time to setting used in the * boot bus timing register, based on timing multiple */ @@ -114,7 +114,7 @@ static void octeon_cf_set_boot_reg_cfg(i cvmx_write_csr(CVMX_MIO_BOOT_REG_CFGX(cs), reg_cfg.u64); } -/** +/* * Called after libata determines the needed PIO mode. This * function programs the Octeon bootbus regions to support the * timing requirements of the PIO mode. @@ -278,7 +278,7 @@ static void octeon_cf_set_dmamode(struct cvmx_write_csr(cf_port->dma_base + DMA_TIM, dma_tim.u64); } -/** +/* * Handle an 8 bit I/O request. * * @qc: Queued command @@ -317,7 +317,7 @@ static unsigned int octeon_cf_data_xfer8 return buflen; } -/** +/* * Handle a 16 bit I/O request. * * @qc: Queued command @@ -372,7 +372,7 @@ static unsigned int octeon_cf_data_xfer1 return buflen; } -/** +/* * Read the taskfile for 16bit non-True IDE only. */ static void octeon_cf_tf_read16(struct ata_port *ap, struct ata_taskfile *tf) @@ -453,7 +453,7 @@ static int octeon_cf_softreset16(struct return 0; } -/** +/* * Load the taskfile for 16bit non-True IDE only. The device_addr is * not loaded, we do this as part of octeon_cf_exec_command16. */ @@ -525,7 +525,7 @@ static void octeon_cf_dma_setup(struct a ap->ops->sff_exec_command(ap, &qc->tf); } -/** +/* * Start a DMA transfer that was already setup * * @qc: Information about the DMA @@ -580,7 +580,7 @@ static void octeon_cf_dma_start(struct a cvmx_write_csr(cf_port->dma_base + DMA_CFG, mio_boot_dma_cfg.u64); } -/** +/* * * LOCKING: * spin_lock_irqsave(host lock)
Fix a slew of kernel-doc warnings in pata_octeon_cf.c by changing all "/**" comments to "/*" since they are not in kernel-doc format. Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/all/202302101722.5O56RClE-lkp@intel.com/ Cc: David Daney <ddaney@caviumnetworks.com> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: linux-ide@vger.kernel.org --- drivers/ata/pata_octeon_cf.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)