| Message ID | 20221212214112.3775327-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | ata: octeon: Drop empty platform remove function | expand |
On Mon, Dec 12, 2022 at 10:41:12PM +0100, Uwe Kleine-König wrote: > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/ata/ahci_octeon.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c > index b9460b91288f..5021ab3ede49 100644 > --- a/drivers/ata/ahci_octeon.c > +++ b/drivers/ata/ahci_octeon.c > @@ -73,11 +73,6 @@ static int ahci_octeon_probe(struct platform_device *pdev) > return 0; > } > > -static int ahci_octeon_remove(struct platform_device *pdev) > -{ > - return 0; > -} > - > static const struct of_device_id octeon_ahci_match[] = { > { .compatible = "cavium,octeon-7130-sata-uctl", }, > { /* sentinel */ } > @@ -86,7 +81,6 @@ MODULE_DEVICE_TABLE(of, octeon_ahci_match); > > static struct platform_driver ahci_octeon_driver = { > .probe = ahci_octeon_probe, > - .remove = ahci_octeon_remove, > .driver = { > .name = "octeon-ahci", > .of_match_table = octeon_ahci_match, > > base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476 > -- > 2.38.1 > Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
On 12/13/22 06:41, Uwe Kleine-König wrote: > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Applied to for-6.3. Thanks ! > --- > drivers/ata/ahci_octeon.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c > index b9460b91288f..5021ab3ede49 100644 > --- a/drivers/ata/ahci_octeon.c > +++ b/drivers/ata/ahci_octeon.c > @@ -73,11 +73,6 @@ static int ahci_octeon_probe(struct platform_device *pdev) > return 0; > } > > -static int ahci_octeon_remove(struct platform_device *pdev) > -{ > - return 0; > -} > - > static const struct of_device_id octeon_ahci_match[] = { > { .compatible = "cavium,octeon-7130-sata-uctl", }, > { /* sentinel */ } > @@ -86,7 +81,6 @@ MODULE_DEVICE_TABLE(of, octeon_ahci_match); > > static struct platform_driver ahci_octeon_driver = { > .probe = ahci_octeon_probe, > - .remove = ahci_octeon_remove, > .driver = { > .name = "octeon-ahci", > .of_match_table = octeon_ahci_match, > > base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c index b9460b91288f..5021ab3ede49 100644 --- a/drivers/ata/ahci_octeon.c +++ b/drivers/ata/ahci_octeon.c @@ -73,11 +73,6 @@ static int ahci_octeon_probe(struct platform_device *pdev) return 0; } -static int ahci_octeon_remove(struct platform_device *pdev) -{ - return 0; -} - static const struct of_device_id octeon_ahci_match[] = { { .compatible = "cavium,octeon-7130-sata-uctl", }, { /* sentinel */ } @@ -86,7 +81,6 @@ MODULE_DEVICE_TABLE(of, octeon_ahci_match); static struct platform_driver ahci_octeon_driver = { .probe = ahci_octeon_probe, - .remove = ahci_octeon_remove, .driver = { .name = "octeon-ahci", .of_match_table = octeon_ahci_match,
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/ata/ahci_octeon.c | 6 ------ 1 file changed, 6 deletions(-) base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476