diff mbox series

libata: add horkage for ASMedia 1092

Message ID 20211208065853.5270-1-hare@suse.de
State New
Headers show
Series libata: add horkage for ASMedia 1092 | expand

Commit Message

Hannes Reinecke Dec. 8, 2021, 6:58 a.m. UTC
The ASMedia 1092 has a configuration mode which will present a
dummy device; sadly the implementation falsely claims to provide
a device with 100M which doesn't actually exist.
So disable this device to avoid errors during boot.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/ata/libata-core.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Damien Le Moal Dec. 8, 2021, 10:57 a.m. UTC | #1
On 2021/12/08 15:59, Hannes Reinecke wrote:
> The ASMedia 1092 has a configuration mode which will present a
> dummy device; sadly the implementation falsely claims to provide
> a device with 100M which doesn't actually exist.
> So disable this device to avoid errors during boot.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/ata/libata-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 9c05177e09c2..f1a2f0a4ce05 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  	{ "VRFDFC22048UCHC-TE*", NULL,		ATA_HORKAGE_NODMA },
>  	/* Odd clown on sil3726/4726 PMPs */
>  	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },
> +	/* Similar story with ASMedia 1092 */
> +	{ "ASMT109x- Config",	NULL,		ATA_HORKAGE_DISABLE },
>  
>  	/* Weird ATAPI devices */
>  	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },
> 

Doesn't this need a Cc stable ? I can add it.
Hannes Reinecke Dec. 8, 2021, 11:09 a.m. UTC | #2
On 12/8/21 11:57 AM, Damien Le Moal wrote:
> On 2021/12/08 15:59, Hannes Reinecke wrote:
>> The ASMedia 1092 has a configuration mode which will present a
>> dummy device; sadly the implementation falsely claims to provide
>> a device with 100M which doesn't actually exist.
>> So disable this device to avoid errors during boot.
>>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> ---
>>  drivers/ata/libata-core.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 9c05177e09c2..f1a2f0a4ce05 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>>  	{ "VRFDFC22048UCHC-TE*", NULL,		ATA_HORKAGE_NODMA },
>>  	/* Odd clown on sil3726/4726 PMPs */
>>  	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },
>> +	/* Similar story with ASMedia 1092 */
>> +	{ "ASMT109x- Config",	NULL,		ATA_HORKAGE_DISABLE },
>>  
>>  	/* Weird ATAPI devices */
>>  	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },
>>
> 
> Doesn't this need a Cc stable ? I can add it.
> 
Possibly; device has never worked properly.

Cheers,

Hannes
Damien Le Moal Dec. 9, 2021, 2:22 a.m. UTC | #3
On 2021/12/08 15:58, Hannes Reinecke wrote:
> The ASMedia 1092 has a configuration mode which will present a
> dummy device; sadly the implementation falsely claims to provide
> a device with 100M which doesn't actually exist.
> So disable this device to avoid errors during boot.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/ata/libata-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 9c05177e09c2..f1a2f0a4ce05 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  	{ "VRFDFC22048UCHC-TE*", NULL,		ATA_HORKAGE_NODMA },
>  	/* Odd clown on sil3726/4726 PMPs */
>  	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },
> +	/* Similar story with ASMedia 1092 */
> +	{ "ASMT109x- Config",	NULL,		ATA_HORKAGE_DISABLE },
>  
>  	/* Weird ATAPI devices */
>  	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },
> 

Applied to for-5.16-fixes with CC stable added.
Thanks !
diff mbox series

Patch

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 9c05177e09c2..f1a2f0a4ce05 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4416,6 +4416,8 @@  static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "VRFDFC22048UCHC-TE*", NULL,		ATA_HORKAGE_NODMA },
 	/* Odd clown on sil3726/4726 PMPs */
 	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },
+	/* Similar story with ASMedia 1092 */
+	{ "ASMT109x- Config",	NULL,		ATA_HORKAGE_DISABLE },
 
 	/* Weird ATAPI devices */
 	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },