| Message ID | 20211111033430.296597-1-damien.lemoal@opensource.wdc.com |
|---|---|
| State | New |
| Headers | show |
| Series | libata: libahci: declare ahci_shost_attr_group as static | expand |
On Thu, Nov 11, 2021 at 12:34:30PM +0900, Damien Le Moal wrote: > ahci_shost_attr_group is referenced only in drivers/ata/libahci.c. > Declare it as static. Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 28430c093a7f..8a6835bfd18a 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = { }; EXPORT_SYMBOL_GPL(ahci_shost_groups); -struct attribute *ahci_sdev_attrs[] = { +static struct attribute *ahci_sdev_attrs[] = { &dev_attr_sw_activity.attr, &dev_attr_unload_heads.attr, &dev_attr_ncq_prio_supported.attr,
ahci_shost_attr_group is referenced only in drivers/ata/libahci.c. Declare it as static. Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups") Cc: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> --- drivers/ata/libahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)