| Message ID | 20211105015021.38998-1-vulab@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | ata: sata_highbank: Remove unnecessary print function dev_err() | expand |
On 2021/11/05 10:50, Xu Wang wrote: > The print function dev_err() is redundant because > platform_get_irq() already prints an error. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> > --- > drivers/ata/sata_highbank.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c > index 8440203e835e..b29d3f1d64b0 100644 > --- a/drivers/ata/sata_highbank.c > +++ b/drivers/ata/sata_highbank.c > @@ -469,10 +469,8 @@ static int ahci_highbank_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "no irq\n"); > + if (irq < 0) > return irq; > - } > if (!irq) > return -EINVAL; > > Applied. Thanks !
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c index 8440203e835e..b29d3f1d64b0 100644 --- a/drivers/ata/sata_highbank.c +++ b/drivers/ata/sata_highbank.c @@ -469,10 +469,8 @@ static int ahci_highbank_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "no irq\n"); + if (irq < 0) return irq; - } if (!irq) return -EINVAL;
The print function dev_err() is redundant because platform_get_irq() already prints an error. Signed-off-by: Xu Wang <vulab@iscas.ac.cn> --- drivers/ata/sata_highbank.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)