| Message ID | 20200121012827.1036-1-chenzhou10@huawei.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | [-next] ata: pata_macio: fix comparing pointer to 0 | expand |
On 1/21/20 2:28 AM, Chen Zhou wrote: > Fixes coccicheck warning: > > ./drivers/ata/pata_macio.c:982:31-32: > WARNING comparing pointer to 0, suggest !E > > Compare pointer-typed values to NULL rather than 0. > > Signed-off-by: Chen Zhou <chenzhou10@huawei.com> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/ata/pata_macio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c > index 1bfd015..e47a282 100644 > --- a/drivers/ata/pata_macio.c > +++ b/drivers/ata/pata_macio.c > @@ -979,7 +979,7 @@ static void pata_macio_invariants(struct pata_macio_priv *priv) > priv->aapl_bus_id = bidp ? *bidp : 0; > > /* Fixup missing Apple bus ID in case of media-bay */ > - if (priv->mediabay && bidp == 0) > + if (priv->mediabay && !bidp) > priv->aapl_bus_id = 1; > } >
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c index 1bfd015..e47a282 100644 --- a/drivers/ata/pata_macio.c +++ b/drivers/ata/pata_macio.c @@ -979,7 +979,7 @@ static void pata_macio_invariants(struct pata_macio_priv *priv) priv->aapl_bus_id = bidp ? *bidp : 0; /* Fixup missing Apple bus ID in case of media-bay */ - if (priv->mediabay && bidp == 0) + if (priv->mediabay && !bidp) priv->aapl_bus_id = 1; }
Fixes coccicheck warning: ./drivers/ata/pata_macio.c:982:31-32: WARNING comparing pointer to 0, suggest !E Compare pointer-typed values to NULL rather than 0. Signed-off-by: Chen Zhou <chenzhou10@huawei.com> --- drivers/ata/pata_macio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)