Message ID | 20180622110307.31523-1-geert@linux-m68k.org |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
Series | [v4] ata: Remove depends on HAS_DMA in case of platform dependency | expand |
On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific > symbol, or PCI. > > Generic symbols and drivers without platform dependencies keep their > dependencies on HAS_DMA, to prevent compiling subsystems or drivers that > cannot work anyway. > > This simplifies the dependencies, and allows to improve compile-testing. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Reviewed-by: Mark Brown <broonie@kernel.org> > Acked-by: Robin Murphy <robin.murphy@arm.com> This looks fine to me but how do you wanna route it? Should I apply it to for-4.18-fixes or should it go with arch changes in some other tree? Thanks.
Hi Tejun, On Mon, Jul 2, 2018 at 6:12 PM Tejun Heo <tj@kernel.org> wrote: > On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote: > > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > > In most cases this other symbol is an architecture or platform specific > > symbol, or PCI. > > > > Generic symbols and drivers without platform dependencies keep their > > dependencies on HAS_DMA, to prevent compiling subsystems or drivers that > > cannot work anyway. > > > > This simplifies the dependencies, and allows to improve compile-testing. > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Reviewed-by: Mark Brown <broonie@kernel.org> > > Acked-by: Robin Murphy <robin.murphy@arm.com> > > This looks fine to me but how do you wanna route it? Should I apply > it to for-4.18-fixes or should it go with arch changes in some other > tree? Please queue it in the ata tree. There are no related arch changes. Thanks! Gr{oetje,eeting}s, Geert
On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific > symbol, or PCI. > > Generic symbols and drivers without platform dependencies keep their > dependencies on HAS_DMA, to prevent compiling subsystems or drivers that > cannot work anyway. > > This simplifies the dependencies, and allows to improve compile-testing. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Reviewed-by: Mark Brown <broonie@kernel.org> > Acked-by: Robin Murphy <robin.murphy@arm.com> Applied to libata/for-4.18-fixes. Thanks.
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 2b16e7c8fff35764..39b181d6bd0d8cf2 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -398,7 +398,6 @@ config SATA_DWC_VDEBUG config SATA_HIGHBANK tristate "Calxeda Highbank SATA support" - depends on HAS_DMA depends on ARCH_HIGHBANK || COMPILE_TEST help This option enables support for the Calxeda Highbank SoC's @@ -408,7 +407,6 @@ config SATA_HIGHBANK config SATA_MV tristate "Marvell SATA support" - depends on HAS_DMA depends on PCI || ARCH_DOVE || ARCH_MV78XX0 || \ ARCH_MVEBU || ARCH_ORION5X || COMPILE_TEST select GENERIC_PHY