From patchwork Tue Jun 19 16:12:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 931717 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="W54ICdR8"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 419Cg75N6Qz9s5c for ; Wed, 20 Jun 2018 02:13:07 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966870AbeFSQNF (ORCPT ); Tue, 19 Jun 2018 12:13:05 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:50233 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966800AbeFSQNC (ORCPT ); Tue, 19 Jun 2018 12:13:02 -0400 Received: by mail-it0-f67.google.com with SMTP id u4-v6so1188726itg.0 for ; Tue, 19 Jun 2018 09:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0+v9zRf1ZsJ+3k2j5D+DJIF+hvUGhq0tbYYWMgFvqYk=; b=W54ICdR8YAffSFWFPgjruy/Op9BFgch5uO6ROwlLAm+7Rn3WEWVT2aobIy92k/3PXP 74JNAyUlEff4nTOvPi0PYKhlXXHO9OK6amRJJ/8dLXhEV7td0lfJOKDSo9KCk4pdMo1T kM++IcPYFelix3X8uOL3WcvbejiA7iJHn9Gpha5uvPHvkPtzoRVPFL0Uztv6iRjdRFhY 6Uf0/M2yLXqmh3USaQuUXZDR7Dfc3w2QHV7cDAXrifKfLOBTHQI9TF47JF+kS3wbrms6 WF6DyEd5a6QnRqcmG1GRhBcJ2G+2Ex4Qurd6X4vrM1SNmefroowP75uu1xcZFrfsB/0I 8WcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0+v9zRf1ZsJ+3k2j5D+DJIF+hvUGhq0tbYYWMgFvqYk=; b=P+vgtHavaYZ7fMBUaj5gKC5ntBUb1KOl7FzxrbiPwEtdJ1Zm5FNbsA/6O01FpZRemg KBIy+g1AfCTaRBbYM0Ru1Z49Ox40AZlqU6rkqso6r6r6/VMZHPUin2ZeL5FRB3JeW2uJ Q7DvKPhnPfvdAW7f1yGpZNs7fE+fyxYYf1xxX7OdcW9LoFQATEcQpPqhvuyI3eErRKJr OXa40/s3FK8Xsla0ysFL2uhjaW0xLdjDr2T+G9sUKGjmnS8t/MwXdbWX7MgZ5RdhrpoJ R9tHeH8cDYaQlJzauPg2aNExlvouWxOTdo9ZK9YoE5fYrv3j8ri0t+Klp+tQfyNM5qG2 KhAg== X-Gm-Message-State: APt69E29tW2R4pGf2bg2HG/rMkNpi7rweNJ0pR5pmqawmWU80u4I6cBG OWX2jemWgeFrZxVJnszj8Ak3ZrujmCM= X-Google-Smtp-Source: ADUXVKLx2cdQO5Ilny5vq73cV/pWkSHEXI6cUF955waGqpFyeciee3BbDFpzF8HDLLXcuiv48N+oIA== X-Received: by 2002:a24:ce86:: with SMTP id v128-v6mr4786436itg.39.1529424781837; Tue, 19 Jun 2018 09:13:01 -0700 (PDT) Received: from x1.thefacebook.com ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id y36-v6sm241432ita.4.2018.06.19.09.13.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jun 2018 09:13:00 -0700 (PDT) From: Jens Axboe To: linux-ide@vger.kernel.org Cc: tj@kernel.org, mpe@ellerman.id.au, Jens Axboe Subject: [PATCH 4/4] sata_fsl: remove dead code in tag retrieval Date: Tue, 19 Jun 2018 10:12:51 -0600 Message-Id: <20180619161251.31613-5-axboe@kernel.dk> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180619161251.31613-1-axboe@kernel.dk> References: <20180619161251.31613-1-axboe@kernel.dk> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org We can never pass in the internal tag to this helper, it'll always be the hardware tag. So there's no need to check and do an internal translation of that tag. Signed-off-by: Jens Axboe --- drivers/ata/sata_fsl.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index bb5ec5f71e73..4dc528bf8e85 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -395,12 +395,6 @@ static inline unsigned int sata_fsl_tag(unsigned int tag, { /* We let libATA core do actual (queue) tag allocation */ - /* all non NCQ/queued commands should have tag#0 */ - if (ata_tag_internal(tag)) { - DPRINTK("mapping internal cmds to tag#0\n"); - return 0; - } - if (unlikely(tag >= SATA_FSL_QUEUE_DEPTH)) { DPRINTK("tag %d invalid : out of range\n", tag); return 0;