From patchwork Tue Jun 19 16:12:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 931716 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="So4JF5dU"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 419Cg53MW3z9s7M for ; Wed, 20 Jun 2018 02:13:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966969AbeFSQND (ORCPT ); Tue, 19 Jun 2018 12:13:03 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:39596 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966870AbeFSQNA (ORCPT ); Tue, 19 Jun 2018 12:13:00 -0400 Received: by mail-it0-f68.google.com with SMTP id p185-v6so1179274itp.4 for ; Tue, 19 Jun 2018 09:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eiHaDNwwbGATqzzIrWM+vs1Znl/9O9WRGbf8TRpHJgo=; b=So4JF5dUaMmK4Fgl3phUecqI6wkg1IFLibzWEya202R2atZRjjJg+LeY0Scioqg2ik lcQU0kzuqO4AY+U0ATlYr2RZWF5SfGGWyPDG3xsB5mm7mG1dRrH92av4JjdiNvPh3G0F wddSdu8/VL+WiwlTrGr6taOTVfaT7oLZzoYNfmybOB8dFnKwI8F3kE3apGV2obCLNRFB jKA1RNCs8LWxqwEn2XmZDQDN1CkZM6ajSbDvpkRFCqamg5Yao1aAXvriOtsBZLZYMaJx WAeH4z/I4zwJJoQfc0QGJI3kErulojYI3GzRZabfAnXfg++vNsgwvQ9lQJwC3Zn58P6R ouSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eiHaDNwwbGATqzzIrWM+vs1Znl/9O9WRGbf8TRpHJgo=; b=ZA6mhX1jqT6gLAgkr27+DRkad0sbeaNSNSiiIxoRhHvjLcApR2Vvy6QN2lLX90fSRG qiALhBS5QX9vx0JUOcvSmc93JPtskDHV610fJ1MgSqYKWDFgcalFpyT+bd/j7ieQxdc6 t5J2SasOPN8F268ic1SFr9uWEFSp2oAEycfEph/c7UUOULJR4zwV7Sq7nrPGLCGFsMv3 y7W4w5AyU27fg25kxR0zA+uJZerA2yTHSy/phmi+7LcUQuuclD7Zti3E89LUlZRZfULR c1Yt7wjIQssPDtbj7qO/fwAtdxEThBanj45ywcLZepvku+T3448eSKXch3SdGOoZbt3Y MWWQ== X-Gm-Message-State: APt69E3iEktyslUypVb0/0ZF6pCj5RLy3jg+iePyztxLi2/FGYg4OPKQ BQCHfiqeq0l/m9VHmDaFw/Xtuau1C6E= X-Google-Smtp-Source: ADUXVKLyfIrAf7AQt2HdstWXS+5Bvur4ByQPe+OMTIQLlOxvo5Y4f4vIp1lKGLUluTUkJadwq0lLgQ== X-Received: by 2002:a24:2e43:: with SMTP id i64-v6mr13541086ita.0.1529424779961; Tue, 19 Jun 2018 09:12:59 -0700 (PDT) Received: from x1.thefacebook.com ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id y36-v6sm241432ita.4.2018.06.19.09.12.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jun 2018 09:12:58 -0700 (PDT) From: Jens Axboe To: linux-ide@vger.kernel.org Cc: tj@kernel.org, mpe@ellerman.id.au, Jens Axboe Subject: [PATCH 3/4] sata_fsl: convert to command iterator Date: Tue, 19 Jun 2018 10:12:50 -0600 Message-Id: <20180619161251.31613-4-axboe@kernel.dk> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180619161251.31613-1-axboe@kernel.dk> References: <20180619161251.31613-1-axboe@kernel.dk> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org We need to iterate all commands, including the internal one, for ATAPI error handling. Fixes: 28361c403683 ("libata: add extra internal command") Signed-off-by: Jens Axboe --- drivers/ata/sata_fsl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index b8d9cfc60374..bb5ec5f71e73 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -1229,8 +1229,7 @@ static void sata_fsl_host_intr(struct ata_port *ap) /* Workaround for data length mismatch errata */ if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) { - for (tag = 0; tag < ATA_MAX_QUEUE; tag++) { - qc = ata_qc_from_tag(ap, tag); + ata_qc_for_each_with_internal(ap, qc, tag) { if (qc && ata_is_atapi(qc->tf.protocol)) { u32 hcontrol; /* Set HControl[27] to clear error registers */