| Message ID | 20180509002812.13151-4-damien.lemoal@wdc.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | libata fixes and improvements | expand |
On 05/09/2018 02:28 AM, Damien Le Moal wrote: > For a successful setting of the device transfer speed mode in > ata_dev_set_mode(), do not print the message > "ataX.XX: configured for xxx" if the EH context has the quiet flag set, > unless the device port is being reset. > > This preserves the output of the message during device scan but removes > it in the case of a simple device revalidation such as trigerred by > enabling the NCQ I/O priority feature of the device > e.g. echo 1 > /sys/block/sdxx/device/ncq_iprio_enable > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > drivers/ata/libata-core.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 68596bd4cf06..f65c62bff229 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -3573,9 +3573,11 @@ static int ata_dev_set_mode(struct ata_device *dev) > DPRINTK("xfer_shift=%u, xfer_mode=0x%x\n", > dev->xfer_shift, (int)dev->xfer_mode); > > - ata_dev_info(dev, "configured for %s%s\n", > - ata_mode_string(ata_xfer_mode2mask(dev->xfer_mode)), > - dev_err_whine); > + if (!(ehc->i.flags & ATA_EHI_QUIET) || > + ehc->i.flags & ATA_EHI_DID_HARDRESET) > + ata_dev_info(dev, "configured for %s%s\n", > + ata_mode_string(ata_xfer_mode2mask(dev->xfer_mode)), > + dev_err_whine); > > return 0; > > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 68596bd4cf06..f65c62bff229 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3573,9 +3573,11 @@ static int ata_dev_set_mode(struct ata_device *dev) DPRINTK("xfer_shift=%u, xfer_mode=0x%x\n", dev->xfer_shift, (int)dev->xfer_mode); - ata_dev_info(dev, "configured for %s%s\n", - ata_mode_string(ata_xfer_mode2mask(dev->xfer_mode)), - dev_err_whine); + if (!(ehc->i.flags & ATA_EHI_QUIET) || + ehc->i.flags & ATA_EHI_DID_HARDRESET) + ata_dev_info(dev, "configured for %s%s\n", + ata_mode_string(ata_xfer_mode2mask(dev->xfer_mode)), + dev_err_whine); return 0;
For a successful setting of the device transfer speed mode in ata_dev_set_mode(), do not print the message "ataX.XX: configured for xxx" if the EH context has the quiet flag set, unless the device port is being reset. This preserves the output of the message during device scan but removes it in the case of a simple device revalidation such as trigerred by enabling the NCQ I/O priority feature of the device e.g. echo 1 > /sys/block/sdxx/device/ncq_iprio_enable Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- drivers/ata/libata-core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)