From patchwork Wed May 9 00:28:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 910577 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="S7xyBQp7"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40gcdt1FWHz9s3D for ; Wed, 9 May 2018 10:28:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932802AbeEIA2Q (ORCPT ); Tue, 8 May 2018 20:28:16 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:25942 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932475AbeEIA2Q (ORCPT ); Tue, 8 May 2018 20:28:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1525825696; x=1557361696; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=dl4tEI4rm8n0j8OSBU0UYfTUNCzUq6BURYVtC/ulcD4=; b=S7xyBQp7dy2wHHlvLQOtHZ3JmCDqPHszMD2lXG7VlLtFUV/fXPzNOiq5 l5tX2EM9MQs9iJ7el7V68hgAwtPibrg7RUvEfcqLftZRiuKKFAYd7hV6G /XfMjyu8ExHvs9fWJq6tLmziHVBOp71HDwoLQAe5+i/zoEzY75Z9GdodX rdUeoO83m4HQuf5UMZ5kaHV/co63wBcspxTjIs9OeeKUla6NhEEyZD87d zITVNadBqzuDEBp6ME5baWyfqjauoYoevlxd+bdk2lpNr7MNmtrsFixEi hOQPR/GNyNsRSBgF7AbUIAFhvSiOcwrnbx5GgDMZo1eG8g/tOiQYAgA3e Q==; X-IronPort-AV: E=Sophos;i="5.49,379,1520870400"; d="scan'208";a="180758036" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 09 May 2018 08:28:16 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP; 08 May 2018 17:19:55 -0700 Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip01.wdc.com with ESMTP; 08 May 2018 17:28:15 -0700 From: Damien Le Moal To: linux-ide@vger.kernel.org, Tejun Heo Cc: "Martin K . Petersen" , Hannes Reinecke , Bart Van Assche Subject: [PATCH 2/5] libata: Fix ata_err_string() Date: Wed, 9 May 2018 09:28:09 +0900 Message-Id: <20180509002812.13151-3-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180509002812.13151-1-damien.lemoal@wdc.com> References: <20180509002812.13151-1-damien.lemoal@wdc.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Add proper error string output for ATA_ERR_NCQ and ATA_ERR_NODEV_HINT instead of returning "unknown error". Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index d7b84bc64ae1..c6871c0749f7 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -1483,6 +1483,10 @@ static const char *ata_err_string(unsigned int err_mask) return "invalid argument"; if (err_mask & AC_ERR_DEV) return "device error"; + if (err_mask & AC_ERR_NCQ) + return "NCQ error"; + if (err_mask & AC_ERR_NODEV_HINT) + return "Polling detection error"; return "unknown error"; }