| Message ID | 20180504142446.30525-2-bigeasy@linutronix.de |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | avoid disabling interrupts where it is not required | expand |
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Date: Fri, 4 May 2018 16:24:43 +0200 > init_chipset_ali15x3() initializes the chipset during init with disabled > interrupts. There is no need to keep the interrupts disabled during > pci_dev_put(). > Move the irq-restore before pci_dev_put() is invoked. > > Side note: The same init is performed in > drivers/ata/pata_ali.c::ali_init_chipset() without disabled interrupts. > It looks that the same hardware is supported in the ATA land. Would it > make sense to remove this driver since it is supported in the other > subsystem? > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: David S. Miller <davem@davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ide/alim15x3.c b/drivers/ide/alim15x3.c index 36f76e28a0bf..3265970aee34 100644 --- a/drivers/ide/alim15x3.c +++ b/drivers/ide/alim15x3.c @@ -323,9 +323,9 @@ static int init_chipset_ali15x3(struct pci_dev *dev) pci_write_config_byte(dev, 0x53, tmpbyte); } + local_irq_restore(flags); pci_dev_put(north); pci_dev_put(isa_dev); - local_irq_restore(flags); return 0; }
init_chipset_ali15x3() initializes the chipset during init with disabled interrupts. There is no need to keep the interrupts disabled during pci_dev_put(). Move the irq-restore before pci_dev_put() is invoked. Side note: The same init is performed in drivers/ata/pata_ali.c::ali_init_chipset() without disabled interrupts. It looks that the same hardware is supported in the ATA land. Would it make sense to remove this driver since it is supported in the other subsystem? Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/ide/alim15x3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)