From patchwork Mon Jul 22 21:13:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 260802 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A7D392C0082 for ; Tue, 23 Jul 2013 07:13:14 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757742Ab3GVVNN (ORCPT ); Mon, 22 Jul 2013 17:13:13 -0400 Received: from mail-qa0-f50.google.com ([209.85.216.50]:48815 "EHLO mail-qa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757496Ab3GVVNM (ORCPT ); Mon, 22 Jul 2013 17:13:12 -0400 Received: by mail-qa0-f50.google.com with SMTP id f14so894435qak.2 for ; Mon, 22 Jul 2013 14:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=AHUOtYsdfVxk/Bgaz2ce8Si5BLh5FSsCaKwuxSzahi8=; b=spYC0mE6WzpwKE2fis0enuoLi5MJbZWLrRAJlHoi6USUv/qyTx1RX34yeSEzIpwqSJ rANBsSa9tfAC3bvgdkpsQAwvRJziq1l4O5LHBTd0Iq/Ax+8ZpT4wkUgaRbUR3tfGxqfv URr1u2YtMBYrn+BECQBVe2XY4VP37JjLsz5ElWK8y9QLmNtnELkMrc55hBI3eI/5bbCA 6Mpn3UtTuYqRQPh8Y/so/Ni4u88+yum3UDRwl8k/iMvsWGajC1tvXB0jFqrVj3VxQUkO sBb90YHxme6n2m1JLbvR+iWEQjo10nya3g4toZLS5w8550hZ4r+gGsKMMFNpHuTzDqgf E3Ug== X-Received: by 10.229.109.131 with SMTP id j3mr8320781qcp.61.1374527592278; Mon, 22 Jul 2013 14:13:12 -0700 (PDT) Received: from mtj.dyndns.org (nat-pool-rdu-u.redhat.com. [66.187.233.203]) by mx.google.com with ESMTPSA id s8sm43836806qag.8.2013.07.22.14.13.10 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 22 Jul 2013 14:13:11 -0700 (PDT) Date: Mon, 22 Jul 2013 17:13:07 -0400 From: Tejun Heo To: Martin Braure de Calignon Cc: Ben Hutchings , 714295@bugs.debian.org, linux-ide@vger.kernel.org, risc4all@yahoo.com Subject: [PATCH libata/for-3.11-fixes] libata: make it clear that sata_inic162x is experimental Message-ID: <20130722211307.GA16776@mtj.dyndns.org> References: <20130627160606.3447.9939.reportbug@storm.xmen.local> <20130627165114.GK4752@decadent.org.uk> <1372353297.24346.4.camel@phoenix> <20130627173142.GM4752@decadent.org.uk> <1372375714.330.17.camel@phoenix> <1372383087.23847.35.camel@deadeye.wl.decadent.org.uk> <1372427725.23094.17.camel@phoenix> <1372603764.5155.17.camel@deadeye.wl.decadent.org.uk> <20130701061726.GA10717@mtj.dyndns.org> <1372668742.17064.23.camel@phoenix> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1372668742.17064.23.camel@phoenix> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hello, guys. I've committed the following patch to for-3.11-fixes. It's unfortunate but I can't see a good way out at this point. :( Thanks. ------------- 8< ---------------- From bb9696192826a7d9279caf872e95b41bc26c7eff Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Mon, 22 Jul 2013 16:53:36 -0400 sata_inic162x never reached a state where it's reliable enough for production use and data corruption is a relatively common occurrence. Make the driver generate warning about the issues and mark the Kconfig option as experimental. If the situation doesn't improve, we'd be better off making it depend on CONFIG_BROKEN. Let's wait for several cycles and see if the kernel message draws any attention. Signed-off-by: Tejun Heo Reported-by: Martin Braure de Calignon Reported-by: Ben Hutchings Reported-by: risc4all@yahoo.com --- drivers/ata/Kconfig | 2 +- drivers/ata/sata_inic162x.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 80dc988..5cddaf8 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -107,7 +107,7 @@ config SATA_FSL If unsure, say N. config SATA_INIC162X - tristate "Initio 162x SATA support" + tristate "Initio 162x SATA support (Very Experimental)" depends on PCI help This option enables support for Initio 162x Serial ATA. diff --git a/drivers/ata/sata_inic162x.c b/drivers/ata/sata_inic162x.c index e451317..5c54d95 100644 --- a/drivers/ata/sata_inic162x.c +++ b/drivers/ata/sata_inic162x.c @@ -6,6 +6,18 @@ * * This file is released under GPL v2. * + * **** WARNING **** + * + * This driver never worked properly and unfortunately data corruption is + * relatively common. There isn't anyone working on the driver and there's + * no support from the vendor. Do not use this driver in any production + * environment. + * + * http://thread.gmane.org/gmane.linux.debian.devel.bugs.rc/378525/focus=54491 + * https://bugzilla.kernel.org/show_bug.cgi?id=60565 + * + * ***************** + * * This controller is eccentric and easily locks up if something isn't * right. Documentation is available at initio's website but it only * documents registers (not programming model). @@ -807,6 +819,8 @@ static int inic_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) ata_print_version_once(&pdev->dev, DRV_VERSION); + dev_alert(&pdev->dev, "inic162x support is broken with common data corruption issues and will be disabled by default, contact linux-ide@vger.kernel.org if in production use\n"); + /* alloc host */ host = ata_host_alloc_pinfo(&pdev->dev, ppi, NR_PORTS); hpriv = devm_kzalloc(&pdev->dev, sizeof(*hpriv), GFP_KERNEL);