Message ID | 20120726144108.GA2724@localhost.localdomain |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On 07/26/2012 10:41 AM, Aaron Lu wrote: > On Thu, Jul 26, 2012 at 09:43:37AM -0400, Jeff Garzik wrote: >> On 07/26/2012 06:05 AM, Aaron Lu wrote: >>> I can't set a flag in libata-acpi.c since a related function is >>> missing in scsi-misc tree. Will fix this when 3.6-rc1 released. >> What does this mean? Would you be more specific? > The patch "libata-acpi: add ata port runtime D3Cold support" by Lin Ming > introduced a function ata_acpi_wake_dev in libata-acpi.c, and only lives > in libata-next tree but not scsi-misc tree. [...] > Another minor issue is, I need to use the can_power_off and > wakeup_by_user flag of the scsi_device structure in sr patches, but > they are all introduced in patches in libata-next tree, so I have to > re-define them in this patch set. Will cause conflict if James send > these sr patches to Linus. Any way to avoid this? Linus said he just merged the libata patches, so they should appear in the torvalds/linux.git as soon as he pushes out (in the next 12 hours, I'm guessing). Up to James how he wants to coordinate after that... he might pull in Linus's tree into scsi-misc or another solution. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -985,8 +985,10 @@ static void ata_acpi_wake_dev(acpi_handle handle, u32 event, void *context) struct ata_device *ata_dev = context; if (event == ACPI_NOTIFY_DEVICE_WAKE && ata_dev && - pm_runtime_suspended(&ata_dev->sdev->sdev_gendev)) + pm_runtime_suspended(&ata_dev->sdev->sdev_gendev)) { + ata_dev->sdev->wakeup_by_user = 1; scsi_autopm_get_device(ata_dev->sdev); + } } But since there is no such function in scsi-misc tree, I can't set the