Message ID | 20100902212839.GA20070@pengutronix.de |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
From: Wolfram Sang <w.sang@pengutronix.de> Date: Thu, 2 Sep 2010 23:28:39 +0200 > Dunno, if it is correct, though. The strange thing is that the code is like > this for two years and, surprisingly, I don't see the problem with 2.6.33. > Also, the proc-entry for my hard-disk is fine. I can't see any suspicious > commits in the ide-directory except maybe the BKL pushdown had a side-effect > regarding the serialization of the sequence? Ah, too late today to seriously > think about such issues... I don't think it's the BKL pushdown, it seems it would be due to something else to me. Thanks for your analysis and suggested patch, I'll take a look at this. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Thanks for your analysis and suggested patch, I'll take a look at this.
Thanks for your help. If we can't find something, I'll just do a bisect this
weekend.
From: Wolfram Sang <w.sang@pengutronix.de> Date: Fri, 3 Sep 2010 07:53:28 +0200 > >> Thanks for your analysis and suggested patch, I'll take a look at this. > > Thanks for your help. If we can't find something, I'll just do a bisect this > weekend. Frankly, at this point, I'm beginning suspect that the procfs stuff simply never warned at some point in the past and that the IDE code has had this problem for a while. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 03 September 2010 02:34:37 pm David Miller wrote: > From: Wolfram Sang <w.sang@pengutronix.de> > Date: Fri, 3 Sep 2010 07:53:28 +0200 > > > > >> Thanks for your analysis and suggested patch, I'll take a look at this. > > > > Thanks for your help. If we can't find something, I'll just do a bisect this > > weekend. > > Frankly, at this point, I'm beginning suspect that the procfs stuff > simply never warned at some point in the past and that the IDE > code has had this problem for a while. JFYI deprecated procfs stuff has been long gone from atang tree.. Thanks. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c index 4c3d1bf..068cef0 100644 --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c @@ -1448,19 +1448,13 @@ int ide_host_register(struct ide_host *host, const struct ide_port_info *d, if (hwif == NULL) continue; - if (hwif->present) - hwif_register_devices(hwif); - } - - ide_host_for_each_port(i, hwif, host) { - if (hwif == NULL) - continue; - ide_sysfs_register_port(hwif); ide_proc_register_port(hwif); - if (hwif->present) + if (hwif->present) { ide_proc_port_register_devices(hwif); + hwif_register_devices(hwif); + } } return j ? 0 : -1;