diff mbox

: ata: fix unused variable warning in sil_host_intr()

Message ID 20100527173114.23427.67952.sendpatchset@prarit.bos.redhat.com
State Not Applicable
Delegated to: David Miller
Headers show

Commit Message

Prarit Bhargava May 27, 2010, 5:35 p.m. UTC 
Warning seen with 'make -j24 CONFIG_DEBUG_SECTION_MISMATCH=y':

drivers/ata/sata_sil.c: In function ‘sil_host_intr’:
drivers/ata/sata_sil.c:442: error: ‘serror’ may be used uninitialized in this function

Signed-off-by: Prarit Bhargava <prarit@redhat.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Sergei Shtylyov May 27, 2010, 5:48 p.m. UTC | #1 
Hello.

Prarit Bhargava wrote:

    s/unused/uninitialized/ in the subject. Unused variable is a 
different thing.

> Warning seen with 'make -j24 CONFIG_DEBUG_SECTION_MISMATCH=y':

    I don't think any of these matters here...

> drivers/ata/sata_sil.c: In function ‘sil_host_intr’:
> drivers/ata/sata_sil.c:442: error: ‘serror’ may be used uninitialized in this function

> Signed-off-by: Prarit Bhargava <prarit@redhat.com>

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Prarit Bhargava May 27, 2010, 6:02 p.m. UTC | #2 
> Hello.
>
> Prarit Bhargava wrote:
>
>    s/unused/uninitialized/ in the subject. Unused variable is a 
> different thing.

Oops.  Sorry for the typo.

P.


>
>> Warning seen with 'make -j24 CONFIG_DEBUG_SECTION_MISMATCH=y':
>
>    I don't think any of these matters here...
>
>> drivers/ata/sata_sil.c: In function ‘sil_host_intr’:
>> drivers/ata/sata_sil.c:442: error: ‘serror’ may be used 
>> uninitialized in this function
>
>> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>
> MBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c
index 3cb69d5..d7c616c 100644
--- a/drivers/ata/sata_sil.c
+++ b/drivers/ata/sata_sil.c
@@ -439,7 +439,7 @@  static void sil_host_intr(struct ata_port *ap, u32 bmdma2)
 	u8 status;
 
 	if (unlikely(bmdma2 & SIL_DMA_SATA_IRQ)) {
-		u32 serror;
+		u32 uninitialized_var(serror);
 
 		/* SIEN doesn't mask SATA IRQs on some 3112s.  Those
 		 * controllers continue to assert IRQ as long as