From patchwork Tue Oct 20 06:34:56 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoichi Yuasa X-Patchwork-Id: 36436 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 2DA8FB7B79 for ; Tue, 20 Oct 2009 17:34:58 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750781AbZJTGev (ORCPT ); Tue, 20 Oct 2009 02:34:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752269AbZJTGev (ORCPT ); Tue, 20 Oct 2009 02:34:51 -0400 Received: from ey-out-2122.google.com ([74.125.78.27]:21974 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbZJTGev (ORCPT ); Tue, 20 Oct 2009 02:34:51 -0400 Received: by ey-out-2122.google.com with SMTP id 9so1107555eyd.19 for ; Mon, 19 Oct 2009 23:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:cc :subject:message-id:x-mailer:mime-version:content-type :content-transfer-encoding; bh=qoa6NJUPjhDtgf6qfXIcbM4EyfqqkJbUwC6sa0aOKNg=; b=iAc1qN0raYwn9Gbhz1yqX9EnFdnFHC0KQpoJKuNlZcBAuZkrq0mctQ/q6Ov0lEOO/W ao+GTAFUwZC3bxc7Apym/yO67OFdCgCIk4uxCTvfix8GiHCJrzzZZpG33NgqvPNyI6dl GEnAh4EDkjdPZoyEgS1UWI/SEM4u2EuamPAMo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; b=cKtxcmcQUOISBUuzw19CtsOrHIUYw9DR8WTEeMCl3P8uhhC9YYYEp7Ux8D6hjEpqyp 8haNLS/drn9iQVMOxiNK0liucNP6xtGKqx+av34Y2Ihn8EGb91S9LshUVH9rT2cUwdHK 1JH6hHfQT3FOgULr6mIyxgEn8mX/GKu2cK30M= Received: by 10.216.85.134 with SMTP id u6mr2140368wee.213.1256020494834; Mon, 19 Oct 2009 23:34:54 -0700 (PDT) Received: from ypsilon.skybright.jp (sannin29006.nirai.ne.jp [203.160.29.6]) by mx.google.com with ESMTPS id x6sm5896321gvf.16.2009.10.19.23.34.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 19 Oct 2009 23:34:52 -0700 (PDT) Date: Tue, 20 Oct 2009 15:34:56 +0900 From: Yoichi Yuasa To: Jeff Garzik Cc: yuasa@linux-mips.org, linux-ide@vger.kernel.org Subject: [PATCH] sata_sil: fix uninitialized variable use when sil_scr_read() fails Message-Id: <20091020153456.9104e044.yuasa@linux-mips.org> X-Mailer: Sylpheed 2.6.0 (GTK+ 2.16.6; i586-redhat-linux-gnu) Mime-Version: 1.0 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Signed-off-by: Yoichi Yuasa --- drivers/ata/sata_sil.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c index 3cb69d5..d7fff6b 100644 --- a/drivers/ata/sata_sil.c +++ b/drivers/ata/sata_sil.c @@ -439,7 +439,7 @@ static void sil_host_intr(struct ata_port *ap, u32 bmdma2) u8 status; if (unlikely(bmdma2 & SIL_DMA_SATA_IRQ)) { - u32 serror; + u32 serror = 0; /* SIEN doesn't mask SATA IRQs on some 3112s. Those * controllers continue to assert IRQ as long as