| Message ID | 1edabe459c04313f2e9bb4282a7bea208272e618.1307513666.git.viresh.kumar@st.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Hello. Viresh Kumar wrote: > This adds Kconfig options for DEBUG and VERBOSE_DEBUG to the ATA subsystem > Signed-off-by: Viresh Kumar <viresh.kumar@st.com> > --- > drivers/ata/Kconfig | 14 ++++++++++++++ > drivers/ata/Makefile | 2 ++ > 2 files changed, 16 insertions(+), 0 deletions(-) > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 75afa75..d527fbe 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -30,6 +30,20 @@ menuconfig ATA > > if ATA > > +config ATA_DEBUG > + bool "ATA debugging" > + help > + This is an option for use by developers; most people should > + say N here. This enables ATA core and driver debugging. > + > +config ATA_VDEBUG > + bool "ATA verbose debugging" > + depends on ATA_DEBUG != n Why not just on ATA_DEBUG? It can only be 'y' or 'n'. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/08/2011 08:09 PM, Sergei Shtylyov wrote: >> > +config ATA_DEBUG >> > + bool "ATA debugging" >> > + help >> > + This is an option for use by developers; most people should >> > + say N here. This enables ATA core and driver debugging. >> > + >> > +config ATA_VDEBUG >> > + bool "ATA verbose debugging" >> > + depends on ATA_DEBUG != n > Why not just on ATA_DEBUG? It can only be 'y' or 'n'. Yes, that's correct! Will resend it.
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 75afa75..d527fbe 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -30,6 +30,20 @@ menuconfig ATA if ATA +config ATA_DEBUG + bool "ATA debugging" + help + This is an option for use by developers; most people should + say N here. This enables ATA core and driver debugging. + +config ATA_VDEBUG + bool "ATA verbose debugging" + depends on ATA_DEBUG != n + help + This is an option for use by developers; most people should + say N here. This enables deeper (more verbose) debugging of + the ATA core and drivers. + config ATA_NONSTANDARD bool default n diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index 8ac64e1..d0b95a7 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -1,3 +1,5 @@ +ccflags-$(CONFIG_ATA_DEBUG) := -DDEBUG +ccflags-$(CONFIG_ATA_VDEBUG) += -DVERBOSE_DEBUG obj-$(CONFIG_ATA) += libata.o
This adds Kconfig options for DEBUG and VERBOSE_DEBUG to the ATA subsystem Signed-off-by: Viresh Kumar <viresh.kumar@st.com> --- drivers/ata/Kconfig | 14 ++++++++++++++ drivers/ata/Makefile | 2 ++ 2 files changed, 16 insertions(+), 0 deletions(-)