diff mbox

atm: libahci: replace obselete simple_strtoul() with kstrtouint()

Message ID 1983660.RVkLooTtjT@daeseok-laptop.cloud.net
State Not Applicable
Delegated to: David Miller
Headers show

Commit Message

Daeseok Youn Feb. 19, 2014, 5:09 a.m. UTC 
From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Wed, 19 Feb 2014 13:44:24 +0900
Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
 kstrtouint()

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
 drivers/ata/libahci.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

 	pmp = (state & EM_MSG_LED_PMP_SLOT) >> 8;

Comments

David Miller Feb. 19, 2014, 6:05 a.m. UTC | #1 
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Wed, 19 Feb 2014 14:09:49 +0900

> From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Wed, 19 Feb 2014 13:44:24 +0900
> Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
>  kstrtouint()
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>

Please fix your Subject line, you meant "ata: " not "atm: "
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Daeseok Youn Feb. 19, 2014, 6:14 a.m. UTC | #2 
I re-send this patch after fixing subject.
Thanks.

Daeseok Youn

2014-02-19 15:05 GMT+09:00 David Miller <davem@davemloft.net>:
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Wed, 19 Feb 2014 14:09:49 +0900
>
>> From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <daeseok.youn@gmail.com>
>> Date: Wed, 19 Feb 2014 13:44:24 +0900
>> Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
>>  kstrtouint()
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>
> Please fix your Subject line, you meant "ata: " not "atm: "
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov Feb. 19, 2014, 12:40 p.m. UTC | #3 
Hello.

On 19-02-2014 10:05, David Miller wrote:

>>  From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <daeseok.youn@gmail.com>
>> Date: Wed, 19 Feb 2014 13:44:24 +0900
>> Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
>>   kstrtouint()

>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>

> Please fix your Subject line, you meant "ata: " not "atm: "

    And "obsolete". :-)

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 36605ab..417946b 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1032,12 +1032,13 @@  static ssize_t ahci_led_show(struct ata_port *ap, char 
*buf)
 static ssize_t ahci_led_store(struct ata_port *ap, const char *buf,
 				size_t size)
 {
-	int state;
+	unsigned int state;
 	int pmp;
 	struct ahci_port_priv *pp = ap->private_data;
 	struct ahci_em_priv *emp;
 
-	state = simple_strtoul(buf, NULL, 0);
+	if (kstrtouint(buf, 0, &state) < 0)
+		return -EINVAL;
 
 	/* get the slot number from the message */