From patchwork Wed Apr 11 07:50:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 897070 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MdIcEuzv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40LbnV3j5cz9s27 for ; Wed, 11 Apr 2018 17:50:54 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752303AbeDKHux (ORCPT ); Wed, 11 Apr 2018 03:50:53 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:35607 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752297AbeDKHuw (ORCPT ); Wed, 11 Apr 2018 03:50:52 -0400 Received: by mail-it0-f68.google.com with SMTP id q85-v6so1552529itc.0; Wed, 11 Apr 2018 00:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=G7Fgv9rJ6w9JpzYXNQhw1EQj6uiXTk4bfalqyiTpshE=; b=MdIcEuzvOkyvZRU8tm9JksGKJ/wjWV7lY03f2Jn/8NHwXfklk1n5Qj9AWFyujDip/M nvUp5tH3mImO/t6dXNSkSr0TQrlUcWC5l6ndctDc7ocpImIySkW+ZiPkXn12ZGFe+E07 HMhjdnVVYbuouuTntj4WF60oM5wjRjuFvgJry71ECiHqT9ZQZ2mubyI5ZoW+LmJGd1+T 2E0E9Mn0QjnX4hw4hk/XHFHzCMhpuKokkeVQx6z3UyEjnj80JE8999EOzlzIQU5QYYCX HlswmuYcWZQfK3RrMVO+CwjG5g+an/HqlKr6WV5a4WlRZLbnD6s9slz+Z/2Wn0SmcjXn tasw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=G7Fgv9rJ6w9JpzYXNQhw1EQj6uiXTk4bfalqyiTpshE=; b=lMBFFFsz8h+bhH+TYGVvRo4FrPjmysvAygJsTGvfsYEit2Ia1aF+2vVK4GRhJ6E6Cw fHP0QDZdsJLUoo7anO5E9QMotwc5nYRQtpp/AlW/3jC5MQ8oA/QPTtg72dz7wIDCIlP4 cNf0X3qZwWA98MGbwJJlkdrKq5odeiAgicXL49JmOwXeJklo8YAgrvMA33Z1TPyIVE6h aWl3NgA2QUk9tcQqZigqZfBKHZs/oWbtOTVbSAqT5QQzz+8rZv/lPecB24zbhUkkjDvZ IupD+XfcxCuaPvdPLAdp5RRaDl3qbAckb4fk1Ob/yB7inNAbaD2S2FxwpJAD0HIA3gPa /t1A== X-Gm-Message-State: ALQs6tAmuFNVW0qLIzuYSLZWnx9WpQne8tC7tHebLyilkjpg2UanlZYm V+nx3Pb54DyTrIA0Ms9K7Vk= X-Google-Smtp-Source: AIpwx4+jEJKLmW32DcyMvYWjbxj4oXz6IeNXGD3OkVpqZWXSlybiX6xA3efyX3fX8Hm8rQE7vbwyQg== X-Received: by 2002:a24:11:: with SMTP id 17-v6mr2781939ita.111.1523433051868; Wed, 11 Apr 2018 00:50:51 -0700 (PDT) Received: from oslab.tsinghua.edu.cn ([2402:f000:1:4413:edc8:c1dd:b0a8:461d]) by smtp.gmail.com with ESMTPSA id c8-v6sm482555ita.18.2018.04.11.00.50.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Apr 2018 00:50:51 -0700 (PDT) From: Jia-Ju Bai To: davem@davemloft.net, source@mvista.com, alan@lxorguk.ukuu.org.uk Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] ide: hpt366: Replace mdelay with usleep_range in init_chipset_hpt366 Date: Wed, 11 Apr 2018 15:50:43 +0800 Message-Id: <1523433043-3811-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org init_chipset_hpt366() is never called in atomic context. init_chipset_hpt366() is set as ".init_chipset" in struct ide_port_info. This function is not called in atomic context. Despite never getting called from atomic context, init_chipset_hpt366() calls mdelay() to busily wait. This is not necessary and can be replaced with usleep_range() to avoid busy waiting. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai --- drivers/ide/hpt366.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/hpt366.c b/drivers/ide/hpt366.c index 4b5dc01..4045559 100644 --- a/drivers/ide/hpt366.c +++ b/drivers/ide/hpt366.c @@ -984,7 +984,7 @@ static int init_chipset_hpt366(struct pci_dev *dev) for (temp = i = 0; i < 128; i++) { pci_read_config_word(dev, 0x78, &f_cnt); temp += f_cnt & 0x1ff; - mdelay(1); + usleep_range(1000, 2000); } f_cnt = temp / 128; } else