From patchwork Sun Jun 11 14:53:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minwoo Im X-Patchwork-Id: 774372 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wlzY14bXFz9s75 for ; Mon, 12 Jun 2017 00:53:09 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PcodlKD9"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751794AbdFKOxI (ORCPT ); Sun, 11 Jun 2017 10:53:08 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33916 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751764AbdFKOxH (ORCPT ); Sun, 11 Jun 2017 10:53:07 -0400 Received: by mail-pg0-f66.google.com with SMTP id v14so12117575pgn.1 for ; Sun, 11 Jun 2017 07:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=+XQMiO//HNhTNsknCkk/b9RRPaWJEptGWsRJ4czvYuU=; b=PcodlKD9zG8LiuI07+joGagH022bTmy73qeTSJGOlmJAgv0c8TPwlT+VEfZ67pzScQ 2sFQIY1/4mKAn5c9XDjDROSH+I/heejWsvR6Xj/i2wanPO2IqfvH3iDgUPtJ0pexYWqm ISUHl8I9iB60NswzsNeRmvbrlaY+bjyN8WVhtkY7I4dtW24ztV/Xw3cu1/iXu2+IHKRD zouEhlhIaNGCfgHiB0tDPeubay3JiPHdCxXnENr0uvvQjeGaYWn+NedOBOeEHPKisuCp ZFi8E5xT21mAS5BVvRwwL192H1KlYTSIuRWF9sOhdWz3abWgPMTiCqWwPojlgKoqDVyk cswA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+XQMiO//HNhTNsknCkk/b9RRPaWJEptGWsRJ4czvYuU=; b=mFrako5vvJjobtaUegqgrEAmibcdmUqDU+869V+cALCKeHrVZjTywG62PEtMxGHprM 6gdgfDHo9IfwY7xcSkj76H69+8jUEsys/XaZDaCVSKR7kuwTjdgk6NUnFzCp0unhqXhX A3RSCGcuuFUrJaKqjJvrT73ufuQv36Ah3BWLgCaacHiU4CQCW8r7U8Nsveof+EN75I+W vs2/ykYnChy0oJ9J1WhyKJsel/N+5tx2MIQfE9G7QvXkJlsEwruVs9oJRT3s2ue/UllJ +mztF6qWjhDWCByngsiYtLGSWIdzgystdCnQHtzRy6Q/AZqEmxEtaWLTO1DyPT7bVkpY NHyg== X-Gm-Message-State: AODbwcCBZs6m1PMmUzvNqMOYSeT4HO4e0RnMzBHGUhpmghtr0+OLz7IZ 049HzOKzGoSmng== X-Received: by 10.98.27.215 with SMTP id b206mr17998991pfb.123.1497192787110; Sun, 11 Jun 2017 07:53:07 -0700 (PDT) Received: from Lim-localhost.skbroadband ([61.98.86.106]) by smtp.gmail.com with ESMTPSA id n4sm14179960pgt.3.2017.06.11.07.53.05 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 11 Jun 2017 07:53:06 -0700 (PDT) From: Minwoo Im To: Tejun Heo Cc: linux-ide@vger.kernel.org, Minwoo Im Subject: [PATCH] libahci: wrong comments in ahci_do_softreset() Date: Sun, 11 Jun 2017 23:53:00 +0900 Message-Id: <1497192780-7772-1-git-send-email-dn3108@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org AHCI 1.3.1 Spec says that software shall build two H2D register FISes in the command list to send a software reset. The comments in ahci_do_softreset() is currently D2H instead of H2D. Signed-off-by: Minwoo Im --- drivers/ata/libahci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 3159f9e..835efe4 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1400,7 +1400,7 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, ata_tf_init(link->device, &tf); - /* issue the first D2H Register FIS */ + /* issue the first H2D Register FIS */ msecs = 0; now = jiffies; if (time_after(deadline, now)) @@ -1417,7 +1417,7 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, /* spec says at least 5us, but be generous and sleep for 1ms */ ata_msleep(ap, 1); - /* issue the second D2H Register FIS */ + /* issue the second H2D Register FIS */ tf.ctl &= ~ATA_SRST; ahci_exec_polled_cmd(ap, pmp, &tf, 0, 0, 0);